Skip to content

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Aug 31, 2018

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

  • get()'s options should be optional
  • Add get() to docs
  • get() should return to the Angular zone
  • Since it's Promise-based and doesn't have side-effects, create and use a new simplified runInZone operator

Code sample

@jamesdaniels jamesdaniels requested a review from davideast August 31, 2018 21:25
@jamesdaniels jamesdaniels changed the title fix(afs): get options are optional, zone work, and doc get fix(afs): optional get() options, get() for docs, and zone work Aug 31, 2018
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit 185943f into master Sep 4, 2018
@davideast davideast deleted the get_stuff branch September 4, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants