This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria.ngClick): restrict preventDefault on space / enter to non-… #16680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interactive elements Fixes #16664
petebacondarwin
approved these changes
Sep 2, 2018
test/ngAria/ariaSpec.js
Outdated
| browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 13}); | ||
| browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32}); | ||
|
|
||
| expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)', elementType.toLowerCase() + '(false)']); |
There was a problem hiding this comment.
I think the test would be a bit clearer if you checked clickEvents after each browserTrigger.
Otherwise someone might read this test as "you need to trigger two keydowns to get any events".
…to non-interactive elements
|
Reminder: I pushed the branch to this repo, should delete it after merging |
gkalpak
approved these changes
Sep 4, 2018
test/ngAria/ariaSpec.js
Outdated
| function createHTML(type) { | ||
| var html = '<' + type + '>'; | ||
|
|
||
| if (type === 'INPUT' || 'TYPE' === 'A') return html; |
There was a problem hiding this comment.
The 'TYPE' === 'A' part seems fishy 😛
src/ngAria/aria.js
Outdated
| event.preventDefault(); | ||
| // Prevent the default browser behavior (e.g. scrolling when pressing spacebar) ... | ||
| if (nodeBlackList.indexOf(event.target.nodeName) === -1) { | ||
| // ... but only when the event is triggered by a non-interactive element |
There was a problem hiding this comment.
Nit: I would actually flip the last two comments around:
// If the event is triggered on a non-interactive element...
if (...) {
// ...prevent the default browser behavior...
...…to non-interactive elements
gkalpak
approved these changes
Sep 5, 2018
| if (type === 'INPUT' || 'TYPE' === 'A') return html; | ||
|
|
||
| return html + '</' + type + '>'; | ||
| return '<' + type + '></' + type + '>'; |
There was a problem hiding this comment.
<input></input> is not correct, but will work nonetheless 😃
There was a problem hiding this comment.
Yes, I simply removed it because the browsers don't care ;)
|
For future reference, this fixes a regression introduced in #16604. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…interactive elements
Fixes #16664
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: