Skip to content

Added undescore to ignore new pydocstyle item (backport #428) #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Added undescore to ignore new pydocstyle item (backport #428) #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d26b25
Added underscore to ignore new pydocstyle item (#428)
Crola1702 Jan 3, 2023
79d4337
Fix merge conflicts (#432)
Crola1702 Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ament_pep257/ament_pep257/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ def generate_pep257_report(paths, excludes, ignore):

files_dict = {}
if LooseVersion(pydocstyle.__version__) >= LooseVersion('2.0.0'):
for filename, checked_codes, ignore_decorators in files_to_check:
# Unpack 3 values for pydocstyle <= 6.1.1 and 4 values for pydocstyle >= 6.2.0
for filename, checked_codes, ignore_decorators, *_ in files_to_check:
if _filename_in_excludes(filename, excludes):
continue
files_dict[filename] = {
Expand Down