fix: allow smaller store files in store handler

Author: amalcaraz

src/aleph/handlers/content/store.py

@@ -31,8 +31,9 @@
 from aleph.db.models.account_costs import AccountCostsDb
 from aleph.exceptions import AlephStorageException, UnknownHashError
 from aleph.handlers.content.content_handler import ContentHandler
-from aleph.services.cost import get_total_and_detailed_costs
+from aleph.services.cost import calculate_storage_size, get_total_and_detailed_costs
 from aleph.storage import StorageService
+from aleph.toolkit.constants import MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE
 from aleph.toolkit.costs import are_store_and_program_free
 from aleph.toolkit.timestamp import timestamp_to_datetime, utc_now
 from aleph.types.db_session import DbSession
@@ -217,6 +218,11 @@ async def check_balance(
         if are_store_and_program_free(message):
             return costs
 
+        storage_size = calculate_storage_size(session, content)
+
+        if storage_size and storage_size <= MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE:
+            return costs
+
         current_balance = get_total_balance(address=content.address, session=session)
         current_cost = get_total_cost_for_address(
             session=session, address=content.address

src/aleph/services/cost.py

@@ -535,13 +535,10 @@ def _calculate_storage_costs(
 ) -> List[AccountCostsDb]:
     payment_type = get_payment_type(content)
 
-    if isinstance(content, CostEstimationStoreContent) and content.estimated_size_mib:
-        storage_mib = Decimal(content.estimated_size_mib)
-    else:
-        file = get_file(session, content.item_hash)
-        if not file:
-            return []
-        storage_mib = Decimal(file.size / MiB)
+    storage_mib = calculate_storage_size(session, content)
+
+    if not storage_mib:
+        return []
 
     volume = SizedVolume(CostType.STORAGE, storage_mib, item_hash)
 
@@ -559,6 +556,22 @@ def _calculate_storage_costs(
     )
 
 
+def calculate_storage_size(
+    session: DbSession,
+    content: CostEstimationStoreContent | StoreContent,
+) -> Optional[Decimal]:
+
+    if isinstance(content, CostEstimationStoreContent) and content.estimated_size_mib:
+        storage_mib = Decimal(content.estimated_size_mib)
+    else:
+        file = get_file(session, content.item_hash)
+        if not file:
+            return None
+        storage_mib = Decimal(file.size / MiB)
+
+    return storage_mib
+
+
 def get_detailed_costs(
     session: DbSession,
     content: CostComputableContent,

src/aleph/toolkit/constants.py

@@ -276,3 +276,7 @@
 
 STORE_AND_PROGRAM_COST_DEADLINE_HEIGHT = 22066823
 STORE_AND_PROGRAM_COST_DEADLINE_TIMESTAMP = 1742173859
+
+MAX_FILE_SIZE = 100 * MiB
+MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE = 25 * MiB
+# MAX_UPLOAD_FILE_SIZE = 1000 * MiB (not used?)

src/aleph/web/controllers/storage.py

@@ -11,7 +11,6 @@
 from aiohttp import BodyPartReader, web
 from aiohttp.web_request import FileField
 from aleph_message.models import ItemType
-from mypy.dmypy_server import MiB
 from pydantic import ValidationError
 
 from aleph.chains.signature_verifier import SignatureVerifier
@@ -27,6 +26,7 @@
 )
 from aleph.services.cost import get_total_and_detailed_costs
 from aleph.storage import StorageService
+from aleph.toolkit.constants import MAX_FILE_SIZE, MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE
 from aleph.types.db_session import DbSession
 from aleph.types.message_status import InvalidSignature
 from aleph.utils import item_type_from_hash, run_in_executor
@@ -46,10 +46,6 @@
 
 logger = logging.getLogger(__name__)
 
-MAX_FILE_SIZE = 100 * MiB
-MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE = 25 * MiB
-MAX_UPLOAD_FILE_SIZE = 1000 * MiB
-
 
 async def add_ipfs_json_controller(request: web.Request):
     """Forward the json content to IPFS server and return an hash"""
@@ -109,7 +105,10 @@ async def _verify_message_signature(
 async def _verify_user_balance(
     session: DbSession, content: CostEstimationStoreContent
 ) -> None:
-    if content.estimated_size_mib and content.estimated_size_mib > 25 * MiB:
+    if (
+        content.estimated_size_mib
+        and content.estimated_size_mib > MAX_UNAUTHENTICATED_UPLOAD_FILE_SIZE
+    ):
         current_balance = get_total_balance(session=session, address=content.address)
         current_cost = get_total_cost_for_address(
             session=session, address=content.address