Skip to content

Conversation

@anpin
Copy link
Contributor

@anpin anpin commented Jul 9, 2025

Fixes #7726

Changes

DnsExt resolves ManagerClass Type from IDnsProvider instead of hardcoded SimpleDnsManager

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

@anpin
Copy link
Contributor Author

anpin commented Jul 9, 2025

I couldn't find a specific test to run locally in order to verify if my change breaks anything, but that worked for me in another PR

@anpin
Copy link
Contributor Author

anpin commented Jul 9, 2025

seems to be a flaky unrelated test, is it not?

@Aaronontheweb
Copy link
Member

seems to be a flaky unrelated test, is it not?

Yep, it's #7710 rearing its head again

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 000d75b into akkadotnet:dev Jul 11, 2025
9 of 11 checks passed
anpin added a commit to anpin/Akka.Management that referenced this pull request Jul 14, 2025
anpin added a commit to anpin/Akka.Management that referenced this pull request Jul 17, 2025
This was referenced Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DnsExt doesn't respect IDnsProvider.ManagerClass and always uses hard-coded SimpleDnsManager

2 participants