Remove Akka.Persistence.Sql.Common and Akka.Persistence.Query.Sql #7551
Conversation
Deprecated and no longer maintained - part of akkadotnet#7252 close akkadotnet#7550
|
I essentially inlined all of the Akka.Persistence.Sql.Common internals into the Akka.Persistence.Sqlite package. I've kept all of the namespaces exactly as they were before, so there should be no breaking changes for Akka.Persistence.eSqlite users. |
| /// TBD | ||
| /// </summary> | ||
| /// <param name="setup">TBD</param> | ||
| [Obsolete("Getting removed in v1.6")] |
There was a problem hiding this comment.
The batching journals have always been buggy and we're not going to be debugging them anymore. Going to open a separate PR to delete their test suite.
| } | ||
| } | ||
|
|
||
| akka.persistence.query.journal.sql { |
There was a problem hiding this comment.
Inlined the akka.persistence.query.journal.sql into the Akka.Persistence.Sqlite/reference.conf to maintain backwards compat for Sqlite users.
| return VerifyAssembly<PersistenceQuery>(); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Removed these two assemblies from API approvals
|
Looks like we're going to need to clean up documentation before this can be merged in - cc @Arkatufus |
|
The Akka.Persistence.Sqlite test suite is failing - should be an easy fix but this PR isn't going to clear the runway until that gets resolved. |
2 participants
Changes
Deprecated and no longer maintained - part of #7252
close #7550
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):