Akka.Peristence.Query.InMemory: properly unwrap Tagged messages in all queries
#7548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Mar 20, 2025
| /// </summary> | ||
| internal static class MemoryQueryJournalHelpers | ||
| { | ||
| public static EventEnvelope PrepareEnventEnvelope(IPersistentRepresentation message, Offset? offsetHint = null) |
There was a problem hiding this comment.
Added a unified handler for inspecting IPersistentRepresentations and then doing "the right thing" on the other end
| { | ||
| var payload = (Tagged)persistence.Payload; | ||
| replay.ReplyTo.Tell(new ReplayedTaggedMessage(persistence.WithPayload(payload.Payload), replay.Tag, replay.FromOffset + index), ActorRefs.NoSender); | ||
| replay.ReplyTo.Tell(new ReplayedTaggedMessage(persistence, replay.Tag, replay.FromOffset + index), ActorRefs.NoSender); |
There was a problem hiding this comment.
The reason why tagged message queries worked is we unpacked Tagged messages for those specifically here - we've moved that logic instead to all of the abstract persistence query implementations for the InMemory journal.
We preserve the Tagged bits in the messages here because this design also caused us to lose data about all of the tags applicable to this event, not just the ones we asked for.
This was referenced Mar 21, 2025
This was referenced Sep 4, 2025
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7528
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Taggedclass like other persistence providers #7528