-
Couldn't load subscription status.
- Fork 1.1k
Akka.Remote: Endpoint actor cleanup
#7524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akka.Remote: Endpoint actor cleanup
#7524
Conversation
Removing lots of TBDs and applying some refactoring suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed my changes - doesn't look like perf was negatively impacted at all (in fact, looks a bit better but honestly that's within / near MoE)
|
|
||
| AdjustAdaptiveBackup(); | ||
| ScheduleBackoffTimer(); | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all of the local functions to after the return statement
| void UpdateSavedState(EndpointManager.Link key, EndpointManager.ResendState expectedState) | ||
| { | ||
| if (expectedState == null) | ||
| while (true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed recursion in favor of loops
| } | ||
| } | ||
|
|
||
| bool WriteLoop(int count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made both this method and WritePrioLoop no longer use recursion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Removing lots of TBDs and applying some refactoring suggestions
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksAll benchmarks are on .NET 8
This PR's Benchmarks