Implement nullability in streams Buffer #7496
Conversation
| } | ||
| } | ||
|
|
||
| if (_terminating && _buffer.IsEmpty) |
There was a problem hiding this comment.
This is an actual bug, _buffer can be null if _stage._maxBuffer is less than 1. Moved the code to inside the previous if block
| /// </summary> | ||
| /// <returns>TBD</returns> | ||
| T Peek(); | ||
| T? Peek(); |
There was a problem hiding this comment.
Original behavior is that Peek() can return null
| else if (message is Status.Success) | ||
| { | ||
| if (BufferSize == 0 || Buffer.IsEmpty) | ||
| if (Buffer is null || Buffer.IsEmpty) |
| BufferSize = bufferSize; | ||
| OverflowStrategy = overflowStrategy; | ||
| Buffer = bufferSize != 0 ? Implementation.Buffer.Create<T>(bufferSize, maxFixedBufferSize) : null; | ||
| Buffer = bufferSize > 0 ? Implementation.Buffer.Create<T>(bufferSize, maxFixedBufferSize) : null; |
There was a problem hiding this comment.
Although, should we throw an exception here if the bufferSize is less than 0 ?
There was a problem hiding this comment.
I think we should, I just tried to preserve the old behavior
|
Another thing I'm wondering - is there a compelling reason to have a |
|
In |
|
Though for |
|
After thinking on this, yep, there are definitely scenarios where a user might want a |
2 participants
Changes
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):