Fix PublishWithAck response message type (#7673)

Arkatufus · web-flow · commit c4447736dcba · 2025-05-28T17:36:34.000Z
* Fix PublishWithAck response message type

* Update API Approval list
diff --git a/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedMessages.cs b/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedMessages.cs
@@ -441,9 +441,11 @@ public enum PublishFailReason
         MediatorShuttingDown
     }
     
-    public sealed record PublishFailed(PublishWithAck Message, PublishFailReason Reason): IDeadLetterSuppression;
+    public interface IPublishResponse;
     
-    public sealed record PublishSucceeded(PublishWithAck Message): IDeadLetterSuppression;
+    public sealed record PublishFailed(PublishWithAck Message, PublishFailReason Reason): IPublishResponse, IDeadLetterSuppression;
+    
+    public sealed record PublishSucceeded(PublishWithAck Message): IPublishResponse, IDeadLetterSuppression;
 
     /// <summary>
     /// TBD
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt
@@ -281,6 +281,7 @@ namespace Akka.Cluster.Tools.PublishSubscribe
         public static Akka.Cluster.Tools.PublishSubscribe.GetTopics Instance { get; }
     }
     public interface IDistributedPubSubMessage { }
+    public interface IPublishResponse { }
     public sealed class Publish : Akka.Actor.IWrappedMessage, Akka.Cluster.Tools.PublishSubscribe.IDistributedPubSubMessage, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.Publish>
     {
         public Publish(string topic, object message, bool sendOneMessageToEachGroup = False) { }
@@ -297,13 +298,13 @@ namespace Akka.Cluster.Tools.PublishSubscribe
         Timeout = 0,
         MediatorShuttingDown = 1,
     }
-    public sealed class PublishFailed : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
+    public sealed class PublishFailed : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
     {
         public PublishFailed(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message, Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason) { }
         public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
         public Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason { get; set; }
     }
-    public sealed class PublishSucceeded : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
+    public sealed class PublishSucceeded : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
     {
         public PublishSucceeded(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message) { }
         public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt
@@ -281,6 +281,7 @@ namespace Akka.Cluster.Tools.PublishSubscribe
         public static Akka.Cluster.Tools.PublishSubscribe.GetTopics Instance { get; }
     }
     public interface IDistributedPubSubMessage { }
+    public interface IPublishResponse { }
     public sealed class Publish : Akka.Actor.IWrappedMessage, Akka.Cluster.Tools.PublishSubscribe.IDistributedPubSubMessage, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.Publish>
     {
         public Publish(string topic, object message, bool sendOneMessageToEachGroup = False) { }
@@ -297,13 +298,13 @@ namespace Akka.Cluster.Tools.PublishSubscribe
         Timeout = 0,
         MediatorShuttingDown = 1,
     }
-    public sealed class PublishFailed : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
+    public sealed class PublishFailed : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
     {
         public PublishFailed(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message, Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason) { }
         public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
         public Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason { get; set; }
     }
-    public sealed class PublishSucceeded : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
+    public sealed class PublishSucceeded : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
     {
         public PublishSucceeded(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message) { }
         public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -281,6 +281,7 @@ namespace Akka.Cluster.Tools.PublishSubscribe`
`281`	`281`	`public static Akka.Cluster.Tools.PublishSubscribe.GetTopics Instance { get; }`
`282`	`282`	`}`
`283`	`283`	`public interface IDistributedPubSubMessage { }`
	`284`	`+ public interface IPublishResponse { }`
`284`	`285`	`public sealed class Publish : Akka.Actor.IWrappedMessage, Akka.Cluster.Tools.PublishSubscribe.IDistributedPubSubMessage, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.Publish>`
`285`	`286`	`{`
`286`	`287`	`public Publish(string topic, object message, bool sendOneMessageToEachGroup = False) { }`
`@@ -297,13 +298,13 @@ namespace Akka.Cluster.Tools.PublishSubscribe`
`297`	`298`	`Timeout = 0,`
`298`	`299`	`MediatorShuttingDown = 1,`
`299`	`300`	`}`
`300`		`- public sealed class PublishFailed : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>`
	`301`	`+ public sealed class PublishFailed : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>`
`301`	`302`	`{`
`302`	`303`	`public PublishFailed(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message, Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason) { }`
`303`	`304`	`public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }`
`304`	`305`	`public Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason { get; set; }`
`305`	`306`	`}`
`306`		`- public sealed class PublishSucceeded : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>`
	`307`	`+ public sealed class PublishSucceeded : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>`
`307`	`308`	`{`
`308`	`309`	`public PublishSucceeded(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message) { }`
`309`	`310`	`public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }`