chore: clean up build warnings (#7522)

Aaronontheweb · web-flow · commit 5793a6b20394 · 2025-03-18T11:14:19.000-05:00
* fix: replace Assert.True(false) with Assert.Fail to address xUnit2020 warnings

* fix: add ConfigureAwait(false) to async calls in LazySinkSpec to address xUnit1030 warnings

* fix: add ConfigureAwait(false) to async calls in FlowZipSpec to address xUnit1030 warnings

* remove configure await calls

* remove obsolete member

* fix `RouterConfig` warning

* Fix AK1006 warnings by replacing PersistAsync in loops with PersistAllAsync

* API approvals

* used `new` keyword to avoid API hiding warning

* fixed build warnings with `ChildrenContainer`

removed tons of useless XML-DOCs too

* fixed `Volatile.Read` warnings in `Mailbox`

* fix build warnings

Fix CS0659 and CS0420 warnings in core Akka libraries

This commit addresses two types of build warnings:

1. CS0659: Missing GetHashCode implementation
   - Added GetHashCode implementations to classes in EventSequences.cs
   - Converted test classes in AtLeastOnceDeliverySpec.cs to C# records

2. CS0420: Volatile field access warning
   - Removed redundant 'volatile' keyword from _statusDotNotCallMeDirectly field in Mailbox.cs
   - Kept explicit Volatile.Read/Write method calls for proper memory barriers

These changes maintain the original behavior while eliminating the warnings,
improving code quality and maintainability.

* Suppress CS8632 warnings about nullable reference type annotations

This commit addresses the CS8632 warnings that occur when nullable reference type
annotations (like string?) are used in files with #nullable enable directives but
in projects where nullable reference types are not enabled at the project level.

Changes:
1. Added CS8632 to the NoWarn property in src/Directory.Build.props to suppress
   these warnings during build
2. Created a GlobalSuppressions.cs file with a SuppressMessage attribute for CS8632
   with a clear justification

This approach preserves the intent of the code by keeping the #nullable enable
directives and nullable annotations intact, while eliminating the build warnings.
It also maintains forward compatibility if the project later decides to fully
enable nullable reference types across all projects.

* fixed Akka.Coordination API warning

* added API approvals
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -10,7 +10,7 @@
       xUnit1031 is a temporary fix, we will need to pay this technical debt 
       and make everything fully async in the future 
     -->
-    <NoWarn>$(NoWarn);CS1591;xUnit1013;xUnit1031</NoWarn>
+    <NoWarn>$(NoWarn);CS1591;xUnit1013;xUnit1031;CS8632</NoWarn>
     <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
   <!-- Set the language version for C# if we're not inside an F# project -->
diff --git a/src/GlobalSuppressions.cs b/src/GlobalSuppressions.cs
@@ -0,0 +1,9 @@
+// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+// Suppress CS8632 warnings about nullable reference type annotations
+[assembly: SuppressMessage("Style", "CS8632:The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.", Justification = "Files with #nullable enable directives use nullable annotations correctly")] 
diff --git a/src/contrib/testkits/Akka.TestKit.Xunit/XunitAssertions.cs b/src/contrib/testkits/Akka.TestKit.Xunit/XunitAssertions.cs
@@ -23,7 +23,7 @@ public class XunitAssertions : ITestKitAssertions
         /// <param name="args">An optional object array that contains zero or more objects to format.</param>
         public void Fail(string format = "", params object[] args)
         {
-            Assert.True(false, string.Format(format, args));
+            Assert.Fail(string.Format(format, args));
         }
 
         /// <summary>
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCoordination.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCoordination.DotNet.verified.txt
@@ -44,7 +44,6 @@ namespace Akka.Coordination
     {
         public LeaseTimeoutException(string message) { }
         public LeaseTimeoutException(string message, System.Exception innerEx) { }
-        protected LeaseTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
     }
     public sealed class LeaseUsageSettings
     {
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCoordination.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCoordination.Net.verified.txt
@@ -44,7 +44,6 @@ namespace Akka.Coordination
     {
         public LeaseTimeoutException(string message) { }
         public LeaseTimeoutException(string message, System.Exception innerEx) { }
-        protected LeaseTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
     }
     public sealed class LeaseUsageSettings
     {
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
@@ -2078,7 +2078,6 @@ namespace Akka.Actor.Internal
         public virtual bool IsTerminating { get; }
         public System.Collections.Generic.IReadOnlyCollection<Akka.Actor.Internal.ChildRestartStats> Stats { get; }
         public abstract Akka.Actor.Internal.IChildrenContainer Add(string name, Akka.Actor.Internal.ChildRestartStats stats);
-        protected static void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
         public bool Contains(Akka.Actor.IActorRef actor) { }
         public abstract Akka.Actor.Internal.IChildrenContainer Remove(Akka.Actor.IActorRef child);
         public abstract Akka.Actor.Internal.IChildrenContainer Reserve(string name);
@@ -5032,6 +5031,7 @@ namespace Akka.Routing
         public abstract Akka.Actor.ActorBase CreateRouterActor();
         public bool Equals(Akka.Routing.RouterConfig other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
         public virtual bool IsManagementMessage(object message) { }
         public virtual Akka.Actor.Props RoutingLogicController(Akka.Routing.RoutingLogic routingLogic) { }
         public abstract Akka.Util.ISurrogate ToSurrogate(Akka.Actor.ActorSystem system);
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
@@ -2076,7 +2076,6 @@ namespace Akka.Actor.Internal
         public virtual bool IsTerminating { get; }
         public System.Collections.Generic.IReadOnlyCollection<Akka.Actor.Internal.ChildRestartStats> Stats { get; }
         public abstract Akka.Actor.Internal.IChildrenContainer Add(string name, Akka.Actor.Internal.ChildRestartStats stats);
-        protected static void ChildStatsAppender(System.Text.StringBuilder sb, System.Collections.Generic.KeyValuePair<string, Akka.Actor.Internal.IChildStats> kvp, int index) { }
         public bool Contains(Akka.Actor.IActorRef actor) { }
         public abstract Akka.Actor.Internal.IChildrenContainer Remove(Akka.Actor.IActorRef child);
         public abstract Akka.Actor.Internal.IChildrenContainer Reserve(string name);
@@ -5022,6 +5021,7 @@ namespace Akka.Routing
         public abstract Akka.Actor.ActorBase CreateRouterActor();
         public bool Equals(Akka.Routing.RouterConfig other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
         public virtual bool IsManagementMessage(object message) { }
         public virtual Akka.Actor.Props RoutingLogicController(Akka.Routing.RoutingLogic routingLogic) { }
         public abstract Akka.Util.ISurrogate ToSurrogate(Akka.Actor.ActorSystem system);
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.DotNet.verified.txt
@@ -931,6 +931,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public class EventAdapters
     {
@@ -952,6 +953,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public interface IAsyncRecovery
     {
@@ -1121,6 +1123,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public struct Tagged
     {
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistence.Net.verified.txt
@@ -931,6 +931,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public class EventAdapters
     {
@@ -952,6 +953,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public interface IAsyncRecovery
     {
@@ -1121,6 +1123,7 @@ namespace Akka.Persistence.Journal
         public System.Collections.Generic.IEnumerable<object> Events { get; }
         public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }
         public override bool Equals(object obj) { }
+        public override int GetHashCode() { }
     }
     public struct Tagged
     {
diff --git a/src/core/Akka.Coordination/LeaseTimeoutException.cs b/src/core/Akka.Coordination/LeaseTimeoutException.cs
@@ -32,11 +32,5 @@ public LeaseTimeoutException(string message, Exception innerEx)
             : base(message, innerEx)
         {
         }
-
-        protected LeaseTimeoutException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-
-        }
     }
 }
diff --git a/src/core/Akka.Persistence.Tests/AtLeastOnceDeliverySpec.cs b/src/core/Akka.Persistence.Tests/AtLeastOnceDeliverySpec.cs
@@ -15,7 +15,6 @@
 using Xunit;
 using Xunit.Abstractions;
 using FluentAssertions;
-#pragma warning disable CS0659 // Type overrides Object.Equals(object o) but does not override Object.GetHashCode()
 
 namespace Akka.Persistence.Tests
 {
@@ -217,25 +216,17 @@ public ReqSelection(string message)
         }
         
         [Serializable]
-        sealed class ReqAck
+        sealed record ReqAck
         {
             public static readonly ReqAck Instance = new();
             private ReqAck() { }
-            public override bool Equals(object obj)
-            {
-                return obj is ReqAck;
-            }
         }
 
         [Serializable]
-        sealed class InvalidReq
+        sealed record InvalidReq
         {
             public static readonly InvalidReq Instance = new();
             private InvalidReq() { }
-            public override bool Equals(object obj)
-            {
-                return obj is InvalidReq;
-            }
         }
 
         interface IEvt { }
@@ -271,19 +262,7 @@ public AcceptedSelectionReq(string payload, string destinationPath)
         }
 
         [Serializable]
-        sealed class ReqDone : IEvt, IEquatable<ReqDone>
-        {
-            public ReqDone(long id)
-            {
-                Id = id;
-            }
-
-            public long Id { get; private set; }
-            public bool Equals(ReqDone other)
-            {
-                return other != null && other.Id == Id;
-            }
-        }
+        sealed record ReqDone(long Id) : IEvt;
 
         [Serializable]
         sealed class Action : IEquatable<Action>
@@ -318,19 +297,7 @@ public override int GetHashCode()
         }
 
         [Serializable]
-        sealed class ActionAck : IEquatable<ActionAck>
-        {
-            public ActionAck(long id)
-            {
-                Id = id;
-            }
-
-            public long Id { get; private set; }
-            public bool Equals(ActionAck other)
-            {
-                return other != null && other.Id == Id;
-            }
-        }
+        sealed record ActionAck(long Id);
 
         [Serializable]
         sealed class Boom { public static readonly Boom Instance = new(); }
diff --git a/src/core/Akka.Persistence.Tests/PersistentActorSpec.Actors.cs b/src/core/Akka.Persistence.Tests/PersistentActorSpec.Actors.cs
@@ -480,13 +480,15 @@ protected override bool ReceiveCommand(object message)
                     if (cmd != null)
                     {
                         Sender.Tell(cmd.Data);
+                        var events = new List<Evt>();
                         for (int i = 1; i <= 3; i++)
                         {
-                            PersistAsync(new Evt(cmd.Data.ToString() + "-" + (++_counter)), evt =>
-                            {
-                                Sender.Tell("a" + evt.Data.ToString().Substring(1));
-                            });
+                            events.Add(new Evt(cmd.Data.ToString() + "-" + (++_counter)));
                         }
+                        PersistAllAsync(events, evt =>
+                        {
+                            Sender.Tell("a" + evt.Data.ToString().Substring(1));
+                        });
 
                         return true;
                     }
diff --git a/src/core/Akka.Persistence.Tests/PersistentActorSpecAsyncAwait.Actors.cs b/src/core/Akka.Persistence.Tests/PersistentActorSpecAsyncAwait.Actors.cs
@@ -597,11 +597,12 @@ protected override bool ReceiveCommand(object message)
                             await Task.Delay(100);
 
                             Sender.Tell(cmd.Data);
+                            var events = new List<Evt>();
                             for (int i = 1; i <= 3; i++)
                             {
-                                PersistAsync(new Evt(cmd.Data.ToString() + "-" + (++_counter)),
-                                    evt => { Sender.Tell("a" + evt.Data.ToString().Substring(1)); });
+                                events.Add(new Evt(cmd.Data.ToString() + "-" + (++_counter)));
                             }
+                            PersistAllAsync(events, evt => { Sender.Tell("a" + evt.Data.ToString().Substring(1)); });
                         });
 
                         return true;
diff --git a/src/core/Akka.Persistence/Journal/EventSequences.cs b/src/core/Akka.Persistence/Journal/EventSequences.cs
@@ -56,6 +56,17 @@ public override bool Equals(object obj)
         {
             return Equals(obj as IEventSequence);
         }
+
+        /// <summary>
+        /// Returns a hash code for this instance.
+        /// </summary>
+        /// <returns>
+        /// A hash code for this instance, suitable for use in hashing algorithms and data structures like a hash table.
+        /// </returns>
+        public override int GetHashCode()
+        {
+            return typeof(EmptyEventSequence).GetHashCode();
+        }
     }
 
     /// <summary>
@@ -91,6 +102,25 @@ public override bool Equals(object obj)
         {
             return Equals(obj as IEventSequence);
         }
+
+        /// <summary>
+        /// Returns a hash code for this instance.
+        /// </summary>
+        /// <returns>
+        /// A hash code for this instance, suitable for use in hashing algorithms and data structures like a hash table.
+        /// </returns>
+        public override int GetHashCode()
+        {
+            unchecked
+            {
+                int hash = 17;
+                foreach (var item in _events)
+                {
+                    hash = hash * 23 + (item?.GetHashCode() ?? 0);
+                }
+                return hash;
+            }
+        }
     }
 
     /// <summary>
@@ -127,6 +157,17 @@ public override bool Equals(object obj)
         {
             return Equals(obj as IEventSequence);
         }
+
+        /// <summary>
+        /// Returns a hash code for this instance.
+        /// </summary>
+        /// <returns>
+        /// A hash code for this instance, suitable for use in hashing algorithms and data structures like a hash table.
+        /// </returns>
+        public override int GetHashCode()
+        {
+            return _events[0]?.GetHashCode() ?? 0;
+        }
     }
 
     /// <summary>
diff --git a/src/core/Akka.Remote.Tests/AckedDeliverySpec.cs b/src/core/Akka.Remote.Tests/AckedDeliverySpec.cs
@@ -393,7 +393,7 @@ public void SendBuffer_and_ReceiveBuffer_must_correctly_cooperate_with_each_othe
                 global::System.Diagnostics.Debug.WriteLine(string.Join(Environment.NewLine, log));
                 global::System.Diagnostics.Debug.WriteLine("Received: ");
                 global::System.Diagnostics.Debug.WriteLine(string.Join(Environment.NewLine, received.Select(x => x.ToString())));
-                Assert.True(false,"Not all messages were received");
+                Assert.Fail("Not all messages were received");
             }
 
             global::System.Diagnostics.Debug.WriteLine("All messages have been successfully delivered");
diff --git a/src/core/Akka.Streams.Tests/Akka.Streams.Tests.csproj b/src/core/Akka.Streams.Tests/Akka.Streams.Tests.csproj
@@ -5,7 +5,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <Content Include="App.config" />
     <ProjectReference Include="..\Akka.Remote\Akka.Remote.csproj" />
     <ProjectReference Include="..\Akka.Streams\Akka.Streams.csproj" />
     <ProjectReference Include="..\Akka.Streams.TestKit\Akka.Streams.TestKit.csproj" />
diff --git a/src/core/Akka.Streams.Tests/Dsl/LazySinkSpec.cs b/src/core/Akka.Streams.Tests/Dsl/LazySinkSpec.cs
@@ -36,7 +36,7 @@ private static Func<TMat> Fallback<TMat>()
         {
             return () =>
             {
-                Assert.True(false, "Must not call fallback function");
+                Assert.Fail("Must not call fallback function");
                 return default(TMat);
             };
         }
diff --git a/src/core/Akka.Streams.Tests/ScriptedTest.cs b/src/core/Akka.Streams.Tests/ScriptedTest.cs
@@ -312,17 +312,6 @@ protected ScriptedTest(ITestOutputHelper output = null) : base(output)
         {
         }
 
-        [Obsolete("Will be removed after async_testkit conversion is done. Use RunScriptAsync instead")]
-        protected void RunScript<TIn2, TOut2, TMat2>(
-            Script<TIn2, TOut2> script, 
-            ActorMaterializerSettings settings,
-            Func<Flow<TIn2, TIn2, NotUsed>, Flow<TIn2, TOut2, TMat2>> op,
-            int maximumOverrun = 3,
-            int maximumRequest = 3,
-            int maximumBuffer = 3)
-            => RunScriptAsync(script, settings, op, maximumOverrun, maximumRequest, maximumBuffer)
-                .ConfigureAwait(false).GetAwaiter().GetResult();
-        
         protected async Task RunScriptAsync<TIn2, TOut2, TMat2>(
             Script<TIn2, TOut2> script, 
             ActorMaterializerSettings settings,
diff --git a/src/core/Akka.Tests.Shared.Internals/Helpers/XAssert.cs b/src/core/Akka.Tests.Shared.Internals/Helpers/XAssert.cs
@@ -22,7 +22,7 @@ public static class XAssert
         /// </summary>
         public static void Fail(string reason)
         {
-            Assert.True(false, reason);
+            Assert.Fail(reason);
         }
 
         /// <summary>
diff --git a/src/core/Akka/Actor/ActorCell.Children.cs b/src/core/Akka/Actor/ActorCell.Children.cs
diff --git a/src/core/Akka/Actor/ChildrenContainer/Internal/ChildrenContainer.cs b/src/core/Akka/Actor/ChildrenContainer/Internal/ChildrenContainer.cs
diff --git a/src/core/Akka/Actor/ChildrenContainer/Internal/ChildrenContainerBase.cs b/src/core/Akka/Actor/ChildrenContainer/Internal/ChildrenContainerBase.cs
diff --git a/src/core/Akka/Actor/ChildrenContainer/Internal/NormalChildrenContainer.cs b/src/core/Akka/Actor/ChildrenContainer/Internal/NormalChildrenContainer.cs
diff --git a/src/core/Akka/Actor/ChildrenContainer/Internal/TerminatingChildrenContainer.cs b/src/core/Akka/Actor/ChildrenContainer/Internal/TerminatingChildrenContainer.cs
diff --git a/src/core/Akka/Dispatch/Mailbox.cs b/src/core/Akka/Dispatch/Mailbox.cs
diff --git a/src/core/Akka/Pattern/BackoffSupervisor.cs b/src/core/Akka/Pattern/BackoffSupervisor.cs
diff --git a/src/core/Akka/Routing/RouterConfig.cs b/src/core/Akka/Routing/RouterConfig.cs

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public class XunitAssertions : ITestKitAssertions`
`23`	`23`	`/// <param name="args">An optional object array that contains zero or more objects to format.</param>`
`24`	`24`	`public void Fail(string format = "", params object[] args)`
`25`	`25`	`{`
`26`		`- Assert.True(false, string.Format(format, args));`
	`26`	`+ Assert.Fail(string.Format(format, args));`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ namespace Akka.Coordination`
`44`	`44`	`{`
`45`	`45`	`public LeaseTimeoutException(string message) { }`
`46`	`46`	`public LeaseTimeoutException(string message, System.Exception innerEx) { }`
`47`		`- protected LeaseTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }`
`48`	`47`	`}`
`49`	`48`	`public sealed class LeaseUsageSettings`
`50`	`49`	`{`
Original file line number	Diff line number	Diff line change
`@@ -931,6 +931,7 @@ namespace Akka.Persistence.Journal`
`931`	`931`	`public System.Collections.Generic.IEnumerable<object> Events { get; }`
`932`	`932`	`public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }`
`933`	`933`	`public override bool Equals(object obj) { }`
	`934`	`+ public override int GetHashCode() { }`
`934`	`935`	`}`
`935`	`936`	`public class EventAdapters`
`936`	`937`	`{`
`@@ -952,6 +953,7 @@ namespace Akka.Persistence.Journal`
`952`	`953`	`public System.Collections.Generic.IEnumerable<object> Events { get; }`
`953`	`954`	`public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }`
`954`	`955`	`public override bool Equals(object obj) { }`
	`956`	`+ public override int GetHashCode() { }`
`955`	`957`	`}`
`956`	`958`	`public interface IAsyncRecovery`
`957`	`959`	`{`
`@@ -1121,6 +1123,7 @@ namespace Akka.Persistence.Journal`
`1121`	`1123`	`public System.Collections.Generic.IEnumerable<object> Events { get; }`
`1122`	`1124`	`public bool Equals(Akka.Persistence.Journal.IEventSequence other) { }`
`1123`	`1125`	`public override bool Equals(object obj) { }`
	`1126`	`+ public override int GetHashCode() { }`
`1124`	`1127`	`}`
`1125`	`1128`	`public struct Tagged`
`1126`	`1129`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,5 @@ public LeaseTimeoutException(string message, Exception innerEx)`
`32`	`32`	`: base(message, innerEx)`
`33`	`33`	`{`
`34`	`34`	`}`
`35`		`-`
`36`		`- protected LeaseTimeoutException(SerializationInfo info, StreamingContext context)`
`37`		`- : base(info, context)`
`38`		`- {`
`39`		`-`
`40`		`- }`
`41`	`35`	`}`
`42`	`36`	`}`