Skip to content

Commit 9cb5e5d

Browse files
derekmaurocopybara-github
authored andcommitted
Don't match -Wnon-virtual-dtor in the "flags are needed to suppress
warnings in headers". It should fall through to the "don't impose our warnings on others" case. Do this by matching on "-Wno-*" instead of "-Wno*". Fixes abseil#1737 PiperOrigin-RevId: 659548798 Change-Id: I49d7ba7ddcd7be30f946fca90ba9be467181e854
1 parent 372124e commit 9cb5e5d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMake/AbseilHelpers.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ function(absl_cc_library)
195195
# specified platform. Filter both of them out before the successor
196196
# reaches the "^-m" filter.
197197
set(skip_next_cflag ON)
198-
elseif(${cflag} MATCHES "^(-Wno|/wd)")
198+
elseif(${cflag} MATCHES "^(-Wno-|/wd)")
199199
# These flags are needed to suppress warnings that might fire in our headers.
200200
set(PC_CFLAGS "${PC_CFLAGS} ${cflag}")
201201
elseif(${cflag} MATCHES "^(-W|/w[1234eo])")

0 commit comments

Comments
 (0)