[lldb][swig] Use the correct variable in the return statement

gribozavr · gribozavr · commit 65281570afd7 · 2024-08-21T15:29:03.000+02:00
The issue was introduced in llvm#104523. The code introduces the `ret_val` variable but does not use it. Instead it returns a pointer, which gets implicitly converted to bool.
diff --git a/lldb/bindings/python/python-wrapper.swig b/lldb/bindings/python/python-wrapper.swig
@@ -837,7 +837,7 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPython_ShouldHide(
   bool ret_val = result ? PyObject_IsTrue(result) : false;
   Py_XDECREF(result);
 
-  return result;
+  return ret_val;
 }
 
 void *lldb_private::python::SWIGBridge::LLDBSWIGPython_GetDynamicSetting(

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,7 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPython_ShouldHide(`
`837`	`837`	`bool ret_val = result ? PyObject_IsTrue(result) : false;`
`838`	`838`	`Py_XDECREF(result);`
`839`	`839`
`840`		`- return result;`
	`840`	`+ return ret_val;`
`841`	`841`	`}`
`842`	`842`
`843`	`843`	`void *lldb_private::python::SWIGBridge::LLDBSWIGPython_GetDynamicSetting(`