Skip to content

Commit 3e2e190

Browse files
LFDanLuyihuiliao
LFDanLu
and
yihuiliao
authored
chore: add missing placeholders to test apps and stories (#8949)
* chore: add missing placeholders to test apps and stories * add placeholders to next app --------- Co-authored-by: Yihui Liao <[email protected]>
1 parent 836dc5d commit 3e2e190

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

‎examples/s2-next-macros/src/app/Lazy.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export default function Lazy() {
109109
return (
110110
<>
111111
<Section title="Color">
112-
<ColorField label="Primary Color" />
112+
<ColorField placeholder="-" label="Primary Color" />
113113
<ColorSwatchPicker>
114114
<ColorSwatch color="#A00" />
115115
<ColorSwatch color="#f80" />
@@ -153,16 +153,16 @@ export default function Lazy() {
153153
<Checkbox value="baseball">Baseball</Checkbox>
154154
<Checkbox value="basketball">Basketball</Checkbox>
155155
</CheckboxGroup>
156-
<NumberField label="Width" defaultValue={1024} minValue={0} />
156+
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
157157
<RadioGroup label="Favorite pet">
158158
<Radio value="dogs">Dogs</Radio>
159159
<Radio value="cats">Cats</Radio>
160160
</RadioGroup>
161161
<SearchField label="Search" />
162162
<Switch>Low power mode</Switch>
163-
<TextArea label="Description" />
164-
<TextField label="Email" />
165-
<TextField label="Password" />
163+
<TextArea placeholder="Enter a description" label="Description" />
164+
<TextField placeholder="Enter a email" label="Email" />
165+
<TextField placeholder="Enter a password" label="Password" />
166166
<SelectBoxGroup aria-label="Choose a cloud">
167167
<SelectBox id="aws" textValue="Amazon Web Services">
168168
<Server />
@@ -359,7 +359,7 @@ export default function Lazy() {
359359
</Section>
360360

361361
<Section title="Pickers">
362-
<ComboBox label="Favorite Animal">
362+
<ComboBox placeholder="Select a value" label="Favorite Animal">
363363
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
364364
<ComboBoxItem id="cat">Cat</ComboBoxItem>
365365
<ComboBoxItem id="dog">Dog</ComboBoxItem>

‎examples/s2-parcel-example/src/Lazy.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default function Lazy() {
9595
return (
9696
<>
9797
<Section title="Color">
98-
<ColorField label="Primary Color" />
98+
<ColorField placeholder="-" label="Primary Color" />
9999
<ColorSwatchPicker>
100100
<ColorSwatch color="#A00" />
101101
<ColorSwatch color="#f80" />
@@ -139,16 +139,16 @@ export default function Lazy() {
139139
<Checkbox value="baseball">Baseball</Checkbox>
140140
<Checkbox value="basketball">Basketball</Checkbox>
141141
</CheckboxGroup>
142-
<NumberField label="Width" defaultValue={1024} minValue={0} />
142+
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
143143
<RadioGroup label="Favorite pet">
144144
<Radio value="dogs">Dogs</Radio>
145145
<Radio value="cats">Cats</Radio>
146146
</RadioGroup>
147147
<SearchField label="Search" />
148148
<Switch>Low power mode</Switch>
149-
<TextArea label="Description" />
150-
<TextField label="Email" />
151-
<TextField label="Password" />
149+
<TextArea placeholder="Enter a description" label="Description" />
150+
<TextField placeholder="Enter a email" label="Email" />
151+
<TextField placeholder="Enter a password" label="Password" />
152152
<SelectBoxGroup aria-label="Choose a cloud">
153153
<SelectBox id="aws" textValue="Amazon Web Services">
154154
<Server />
@@ -345,7 +345,7 @@ export default function Lazy() {
345345
</Section>
346346

347347
<Section title="Pickers">
348-
<ComboBox label="Favorite Animal">
348+
<ComboBox placeholder="Select a value" label="Favorite Animal">
349349
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
350350
<ComboBoxItem id="cat">Cat</ComboBoxItem>
351351
<ComboBoxItem id="dog">Dog</ComboBoxItem>

‎examples/s2-webpack-5-example/src/Lazy.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default function Lazy() {
9595
return (
9696
<>
9797
<Section title="Color">
98-
<ColorField label="Primary Color" />
98+
<ColorField placeholder="-" label="Primary Color" />
9999
<ColorSwatchPicker>
100100
<ColorSwatch color="#A00" />
101101
<ColorSwatch color="#f80" />
@@ -139,16 +139,16 @@ export default function Lazy() {
139139
<Checkbox value="baseball">Baseball</Checkbox>
140140
<Checkbox value="basketball">Basketball</Checkbox>
141141
</CheckboxGroup>
142-
<NumberField label="Width" defaultValue={1024} minValue={0} />
142+
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
143143
<RadioGroup label="Favorite pet">
144144
<Radio value="dogs">Dogs</Radio>
145145
<Radio value="cats">Cats</Radio>
146146
</RadioGroup>
147147
<SearchField label="Search" />
148148
<Switch>Low power mode</Switch>
149-
<TextArea label="Description" />
150-
<TextField label="Email" />
151-
<TextField label="Password" />
149+
<TextArea placeholder="Enter a description" label="Description" />
150+
<TextField placeholder="Enter a email" label="Email" />
151+
<TextField placeholder="Enter a password" label="Password" />
152152
<SelectBoxGroup aria-label="Choose a cloud">
153153
<SelectBox id="aws" textValue="Amazon Web Services">
154154
<Server />
@@ -345,7 +345,7 @@ export default function Lazy() {
345345
</Section>
346346

347347
<Section title="Pickers">
348-
<ComboBox label="Favorite Animal">
348+
<ComboBox placeholder="Select a value" label="Favorite Animal">
349349
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
350350
<ComboBoxItem id="cat">Cat</ComboBoxItem>
351351
<ComboBoxItem id="dog">Dog</ComboBoxItem>

0 commit comments

Comments
 (0)