Skip to content

feat: Add finalizeLimitOrders function to HyperliquidExecutor.ts #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 11, 2025
Merged

feat: Add finalizeLimitOrders function to HyperliquidExecutor.ts #2716

merged 9 commits into from
Nov 11, 2025

Conversation

@nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Nov 5, 2025 •
edited
Loading

This function is designed to be called by some bot that ingests SwapFlowInitialized events and some other HyperLiquid events to determine when those SwapFlowInitialized events get executed.

Then the bot should pass in the $.quoteNonces and $.minAmountToSend values into the HyperliquidExecutor.finalizeLimitOrders() function

@nicholaspai
feat: Add finalizeLimitOrders function to HyperliquidExecutor.ts
88f0a29 
Open question for how we will compute `limitOrderOuts: BigNumber []` correctly
@nicholaspai
Update HyperliquidExecutor.ts
f94974a
@nicholaspai nicholaspai marked this pull request as ready for review November 5, 2025 15:59
pxrl
pxrl previously approved these changes Nov 6, 2025
View reviewed changes
@nicholaspai nicholaspai requested a review from pxrl November 6, 2025 19:04
@nicholaspai
Copy link
Member Author

nicholaspai commented Nov 6, 2025

@pxrl @bmzig I added a simple script demonstrating how we can use the hyperliquid SDK to read user fills

@bmzig bmzig mentioned this pull request Nov 11, 2025
Draft
@nicholaspai nicholaspai merged commit 4eb5878 into master Nov 11, 2025
3 of 4 checks passed
@nicholaspai nicholaspai deleted the finalize-swaps-hyperliquid branch November 11, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pxrl pxrl pxrl approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@bmzig bmzig Awaiting requested review from bmzig bmzig is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicholaspai @pxrl