Skip to content

Commit 4fa38e3

Browse files
authored
improve: minor natspec and inheritance improvements to ERC-7683 (#637)
1 parent 108be77 commit 4fa38e3

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

contracts/SpokePool.sol

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
pragma solidity ^0.8.0;
33

44
import "./MerkleLib.sol";
5+
import "./erc7683/ERC7683.sol";
56
import "./external/interfaces/WETH9Interface.sol";
67
import "./interfaces/SpokePoolMessageHandler.sol";
78
import "./interfaces/SpokePoolInterface.sol";
@@ -33,7 +34,8 @@ abstract contract SpokePool is
3334
UUPSUpgradeable,
3435
ReentrancyGuardUpgradeable,
3536
MultiCallerUpgradeable,
36-
EIP712CrossChainUpgradeable
37+
EIP712CrossChainUpgradeable,
38+
IDestinationSettler
3739
{
3840
using SafeERC20Upgradeable for IERC20Upgradeable;
3941
using AddressLibUpgradeable for address;
@@ -985,6 +987,13 @@ abstract contract SpokePool is
985987
);
986988
}
987989

990+
/**
991+
* @notice Fills a single leg of a particular order on the destination chain
992+
* @dev ERC-7683 fill function.
993+
* @param orderId Unique order identifier for this order
994+
* @param originData Data emitted on the origin to parameterize the fill
995+
* @param fillerData Data provided by the filler to inform the fill or express their preferences
996+
*/
988997
function fill(
989998
bytes32 orderId,
990999
bytes calldata originData,

0 commit comments

Comments
 (0)