pr review comments

Author: bradegler

.github/actions/secure-setup-terraform/action.yml

@@ -31,11 +31,11 @@ runs:
     - name: 'download-linters'
       shell: 'bash'
       env:
-        release_version: '0.0.11'
-        release_location: 'https://github.com/bradegler/secure-setup-terraform/releases/tag'
+        RELEASE_VERSION: '0.0.11'
+        RELEASE_LOCATION: 'https://github.com/bradegler/secure-setup-terraform/releases/tag'
       run: |-
-        curl -H "Authorization: token ${{ github.token }}" -O "${{env.release_location}}/v${{env.release_version}}/secure-setup-terraform_${{env.release_version}}_linux_amd64.tar.gz"
-        tar xf secure-setup-terraform_${{env.release_version}}_linux_amd64.tar.gz
+        curl -H "Authorization: token ${{ github.token }}" -O "${{env.RELEASE_LOCATION}}/v${{env.RELEASE_VERSION}}/secure-setup-terraform_${{env.RELEASE_VERSION}}_linux_amd64.tar.gz"
+        tar xf secure-setup-terraform_${{env.RELEASE_VERSION}}_linux_amd64.tar.gz
 
     # Recursively search for terraform files in the current repo and run a linter that fails when it finds calls to 'local-exec'
     - name: 'lint-terraform'

.github/workflows/generate-terraform-checksum.yml

@@ -27,7 +27,7 @@ jobs:
   get_and_verify_checksum:
     runs-on: 'ubuntu-latest'
     env:
-      VERSION: ${{ inputs.terraform_version }}
+      VERSION: '${{ inputs.terraform_version }}'
     outputs:
       binary_checksum: '${{ steps.verify-checksum.outputs.binary_checksum }}'
       archive_checksum: '${{ steps.verify-checksum.outputs.archive_checksum }}'
@@ -81,7 +81,7 @@ jobs:
           BIN_SUM=$(shasum -a 256 terraform | cut -d' ' -f1)
 
           # Store the binary and the archive checksums as outputs
-          echo "archive_checksum=${ARCH_SUM}"
-          echo "binary_checksum=${BIN_SUM}"
+          echo "archive_checksum=${ARCH_SUM}" >> $GITHUB_OUTPUT
+          echo "binary_checksum=${BIN_SUM}" >> $GITHUB_OUTPUT
 
           unset GNUPGHOME

.go-version

@@ -35,6 +35,7 @@ type ViolationInstance struct {
 type Linter interface {
 	// Selectors provides a set of file suffixes to search for. '.tf', '.yml', etc.
 	Selectors() []string
+
 	// FindViolations is the specific linter implementation that is applied to each
 	// file to find any lint violations.
 	FindViolations(content []byte, path string) ([]*ViolationInstance, error)