Wait for the kernel to start before setting pod IP (jupyter-server#132)

* wait for kernel to be ready before getting host

* Bump to 0.12.1

Author: Zsailer

data_studio_jupyter_extensions/_version.py

@@ -1 +1 @@
-__version__ = "0.12.0"  # pragma: no cover
+__version__ = "0.12.1"  # pragma: no cover

data_studio_jupyter_extensions/configurables/provisioner.py

@@ -390,6 +390,9 @@ async def _launch_kernel_local_to_local(self) -> KernelConnectionInfo:
         response = await self.nbservice_client.start_kernel(self.kernelspec_id)
         self.process_id = str(response["id"])
 
+        # Wait for that kernel to come online before getting its info.
+        await self.wait_for_ready()
+
         # The local notebook service client *must* return the
         # connection info when the kernel is started, since
         # there might be multiple kernels competing for the
@@ -412,6 +415,9 @@ async def _launch_kernel_local_to_cluster(
         response = await self.nbservice_client.start_kernel(self.kernelspec_id)
         self.process_id = response["id"]
 
+        # Wait for that kernel to come online before getting its info.
+        await self.wait_for_ready()
+
         # Ports and host will depend on the ingress routes
         # set by the kubernetes cluster.
         host, port_map = await self.open_route(self.process_id)
@@ -430,6 +436,9 @@ async def _launch_kernel_cluster_to_cluster(
         response = await self.nbservice_client.start_kernel(self.kernelspec_id)
         self.process_id = response["id"]
 
+        # Wait for that kernel to come online before getting its info.
+        await self.wait_for_ready()
+
         # The connection info should be predetermined by the kernel itself.
         # Get the Host information from the kernel details endpoint.
         kernel_info = await self.nbservice_client.get_kernel_details(self.process_id)
@@ -455,9 +464,6 @@ async def launch_kernel(
         else:  # pragma: no cover
             await self._launch_kernel_cluster_to_cluster()
 
-        # Wait for that kernel to come online.
-        await self.wait_for_ready()
-
         # Return connection info once the Kernel is live.
         return self.connection_info
 

pyproject.toml

@@ -23,7 +23,7 @@ testpaths = [
 ]
 
 [tool.tbump.version]
-current = "0.12.0"
+current = "0.12.1"
 regex = '''
   (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)
   ((?P<channel>a|b|rc|.dev)(?P<release>\d+))?

version

@@ -1 +1 @@
-0.12.0
+0.12.1