Merge pull request #301 from Yubico/release/1.14.0

Release 1.14.0

Author: DennisDyallo

.editorconfig

@@ -1,5 +1,5 @@
 root = true
-# Copyright 2024 Yubico AB
+# Copyright 2025 Yubico AB
 # 
 # Licensed under the Apache License, Version 2.0 (the "License").
 # You may not use this file except in compliance with the License.
@@ -19,7 +19,7 @@ root = true
 
 # IDE0073: File header
 dotnet_diagnostic.ide0073.severity = suggestion
-file_header_template = Copyright 2024 Yubico AB\n\nLicensed under the Apache License, Version 2.0 (the "License").\nYou may not use this file except in compliance with the License.\nYou may obtain a copy of the License at\n\n    http://www.apache.org/licenses/LICENSE-2.0\n\nUnless required by applicable law or agreed to in writing, software\ndistributed under the License is distributed on an "AS IS" BASIS, \nWITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\nSee the License for the specific language governing permissions and\nlimitations under the License.
+file_header_template = Copyright 2025 Yubico AB\n\nLicensed under the Apache License, Version 2.0 (the "License").\nYou may not use this file except in compliance with the License.\nYou may obtain a copy of the License at\n\n    http://www.apache.org/licenses/LICENSE-2.0\n\nUnless required by applicable law or agreed to in writing, software\ndistributed under the License is distributed on an "AS IS" BASIS, \nWITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\nSee the License for the specific language governing permissions and\nlimitations under the License.
 
 # ReSharper properties
 resharper_csharp_wrap_after_declaration_lpar = true

.github/copilot-instructions.md

@@ -0,0 +1,83 @@
+# Copilot Instructions for Yubico.NET.SDK
+
+This document provides instructions for the Copilot coding agent to work efficiently with the Yubico.NET.SDK repository.
+
+## High-Level Details
+
+- **Repository Summary**: The Yubico.NET.SDK is an enterprise-grade, cross-platform SDK for integrating YubiKey functionality into .NET applications. It provides APIs for device communication, cryptography, and management of YubiKey features. The protocols used include FIDO2, CTAPP, OATH, PIV, SCP3, SCP11 and OTP.
+- **Project Type**: This is a .NET library project, consisting of multiple sub-projects.
+- **Languages**: The primary language is C#.
+- **Frameworks and Runtimes**:
+    - .NET Framework 4.7
+    - .NET Standard 2.1
+    - .NET 6 and later
+- **Key Dependencies**: The solution has a dependency on the `Yubico.NativeShims` project, which provides a stable ABI for P/Invoke operations.
+- The project makes use of an .editorconfig file to maintain consistent coding styles across the codebase.
+
+## Build Instructions
+
+To build, test, and validate changes, follow these steps.
+
+### Building the Solution
+
+You can build the entire solution from the root of the repository using the following command:
+
+```bash
+dotnet build Yubico.NET.SDK.sln
+```
+
+Alternatively, you can use the pre-configured build tasks in Visual Studio Code:
+
+- `build project: Yubico.Yubikey`: Builds the `Yubico.YubiKey` project.
+- `dotnet: build`: A general-purpose build task.
+
+### Running Tests
+
+The repository contains both unit and integration tests.
+
+- **Unit Tests**:
+    - `run unit tests: Yubico.YubiKey`: Runs unit tests for the `Yubico.YubiKey` project.
+    - `run unit tests: Yubico.Core`: Runs unit tests for the `Yubico.Core` project.
+
+- **Integration Tests**:
+    - Integration tests require a YubiKey plugged in and are categorized. You can run them using the provided tasks:
+        - `run tests: integration (Simple)`
+        - `run tests: integration (RequiresTouch)`
+        - `run tests: integration (Elevated)`
+        - `run tests: integration (RequiresBio)`
+        - `run tests: integration (RequiresSetup)`
+        - `run tests: integration (RequiresStepDebug)`
+        - `run tests: integration (RequiresFips)`
+
+## Project Layout
+
+- **`Yubico.Core/`**: Contains the platform abstraction layer (PAL) for OS-specific functionality, device enumeration, and utility classes. It connects to devices such as HID and Smart Cards.
+- **`Yubico.YubiKey/`**: The primary assembly with all the classes and types for YubiKey interaction.
+- **`Yubico.NativeShims/`**: An internal project that provides a stable ABI for P/Invoke operations. It is not intended for public use. This is a C project that wraps native code for easier use in .NET.
+- **`contributordocs/`**: Contains detailed documentation for contributors, including coding guidelines, testing procedures, and code flow information.
+- **`.github/workflows/`**: Contains GitHub Actions workflows for continuous integration, including builds, tests, and code analysis.
+
+## Validation and CI
+
+The repository uses GitHub Actions for continuous integration. The following workflows are run on pull requests:
+
+- `build.yml`: Builds the solution.
+- `build-nativeshims.yml`: Builds the native shims C project.
+- `test.yml`: Runs tests on macOS, Windows, and Ubuntu.
+- `codeql-analysis.yml`: Performs static code analysis using CodeQL.
+
+Before submitting a pull request, ensure that your changes build successfully and that all relevant tests pass. Adhering to the coding style is also crucial.
+
+## Documentation
+
+The repository includes XML documentation comments for public APIs. To generate the documentation, use the following command:
+
+```bash
+dotnet docfx docfx.json
+```
+
+This will create a `docs` folder with the generated documentation.
+The published documentation can be found at `https://docs.yubico.com/yesdk/`. You may search this website for specific topics or API references.
+
+## Exceptions
+The exceptions strings are stored in the ./Yubico.Core/src/Resources/ExceptionMessages.resx and ./Yubico.YubiKey/src/Resources/ExceptionMessages.cs files.

.github/workflows/build-nativeshims.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

.github/workflows/build-pull-requests.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -52,7 +52,8 @@ jobs:
         with:
           global-json-file: global.json
 
-      - name: Add local NuGet repository
+      # Add local NuGet repository so that we can use internal pre-release versions
+      - name: Add local NuGet repository for prerelease versions
         run: dotnet nuget add source --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/Yubico/index.json"
 
       - name: Build Yubico.NET.SDK.sln

.github/workflows/build.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -80,21 +80,23 @@ jobs:
       - uses: actions/setup-dotnet@v4
         with:
           global-json-file: "./global.json"
-      - name: Add local NuGet repository
+
+      # Add local NuGet repository if version is not a plain release (i.e., has a suffix, e.g., -prerelease)
+      - name: Add local NuGet repository for non-release versions
+        if: ${{ github.event.inputs.version && (contains(github.event.inputs.version, '-')) }}
         run: dotnet nuget add source --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/Yubico/index.json"
 
-      - name: Modify version for internal builds
-        if: ${{ github.event.inputs.push-to-dev == 'true' }}
+      - name: Set build version
+        if: ${{ github.event.inputs.version }}
         run: |
           $file = gci ./build/Versions.props
           $versionProp = [xml](gc $file.FullName)
-          $versionProp.Project.PropertyGroup.YubicoCoreVersion = "${{ github.event.inputs.version }}"
-          $versionProp.Project.PropertyGroup.YubicoYubiKeyVersion = "${{ github.event.inputs.version }}"
+          $versionProp.Project.PropertyGroup.CommonVersion = "${{ github.event.inputs.version }}"
           $versionProp.Save($file.FullName)
 
       # Build the project
       - name: Build Yubico.NET.SDK.sln
-        run: dotnet pack --configuration Release --nologo --verbosity minimal Yubico.NET.SDK.sln
+        run: dotnet pack --configuration Release --nologo --verbosity minimal -p:treatWarningsAsErrors=true Yubico.NET.SDK.sln 
 
       # Build the documentation
       - name: Build docs
@@ -251,4 +253,4 @@ jobs:
             echo "| --- | --- |" >> $GITHUB_STEP_SUMMARY
             echo "| **Image Tag** | \`${{ env.DOCS_IMAGE_TAG }}\` |" >> $GITHUB_STEP_SUMMARY
             echo "| **Image Hash** | \`${{ env.DOCS_IMAGE_HASH }}\` |" >> $GITHUB_STEP_SUMMARY
-          fi
+          fi

.github/workflows/codeql-analysis.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

.github/workflows/test-macos.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

.github/workflows/test-ubuntu.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

.github/workflows/test-windows.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

.github/workflows/test.yml

@@ -1,4 +1,4 @@
-# Copyright 2021 Yubico AB
+# Copyright 2025 Yubico AB
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.