Reporter changes (#20)

* replacing own scripts with plugins

* unit test and interface updates

* missing type

* update slack alert to contain get files method

* deal with empty dirs

* tsify slack-alert

* update makefile and add tslint config

* lint script correct

Author: YOU54F

e2e/Makefile

@@ -37,7 +37,7 @@ generate-report:
 	npx marge mochareports/*.json -f report-$$(date +'%Y%m%d-%H%M%S') -o mochareports
 
 slack-alert:
-	node scripts/slack/slack-alert.js
+	npx ts-node scripts/slack/slack-alert.ts
 
 docker-build:
 	docker build . -t $(DOCKERIMGNAME)

e2e/cypress/support/commands.ts

@@ -4,7 +4,7 @@ import 'cypress-testing-library/add-commands';
 
 declare global {
   namespace Cypress {
-    type Greeting = {
+    interface Greeting {
       greeting: string,
       name: string
     }

e2e/cypress/support/pageObjects/login.page.ts

@@ -1,7 +1,7 @@
 import { loginIds } from '../dataTestIds/login.ids';
 
 class LoginPage {
-  visit() {
+  public visit() {
     cy.visit('/login');
     cy.url().should('include', 'login')
   }

e2e/cypress/support/step_definitions/examples/customParameterTypes.ts

@@ -1,4 +1,4 @@
-import { Given, Then, When, defineParameterType } from "cypress-cucumber-preprocessor/steps";
+import { defineParameterType, Given, Then, When } from "cypress-cucumber-preprocessor/steps";
 
 const notes = ["A", "B", "C", "D", "E", "F", "G"];
 

e2e/cypress/support/step_definitions/examples/docString.ts

@@ -1,7 +1,7 @@
 import { Given, Then, When } from "cypress-cucumber-preprocessor/steps";
 
 let code = "";
-let variableToVerify = ""; // we are assigning this through eval
+const variableToVerify = ""; // we are assigning this through eval
 
 When("I use DocString for code like this:", (dataString: string) => {
   code = dataString;

e2e/cypress/support/step_definitions/examples/tags_implementation.ts

@@ -1,5 +1,5 @@
-import { Given, Then, When } from "cypress-cucumber-preprocessor/steps";
 import { shouldProceedCurrentStep } from "cypress-cucumber-preprocessor/lib/tagsHelper";
+import { Given, Then, When } from "cypress-cucumber-preprocessor/steps";
 
 let parsedTags: string;
 

e2e/package.json

@@ -7,6 +7,8 @@
   "author": "Yousaf Nabi",
   "license": "ISC",
   "scripts": {
+    "lint":"tslint --project .",
+    "lint-fix":"tslint --project . --fix",
     "cypress:open": "cypress open",
     "cypress:run": "cypress run",
     "cypress:record": "cypress run --record",
@@ -18,10 +20,14 @@
   },
   "dependencies": {
     "@cypress/webpack-preprocessor": "^4.0.3",
-    "@slack/client": "^5.0.0",
+    "@slack/types": "^1.0.0",
+    "@slack/webhook": "^5.0.0",
     "@types/node": "^10.12.11",
     "cypress": "^3.2.0",
     "cypress-failed-log": "^2.5.0",
+    "husky": "^1.3.1",
+    "lint-staged": "^8.1.5",
+    "prettier": "^1.16.4",
     "mocha": "^5.2.0",
     "mocha-junit-reporter": "^1.21.0",
     "mocha-multi-reporters": "^1.1.7",
@@ -31,11 +37,13 @@
     "shelljs": "^0.8.3",
     "sonarqube-scanner": "^2.4.0",
     "ts-loader": "^5.3.3",
+    "ts-node": "^8.0.3",
+    "tslint": "^5.15.0",
+    "tslint-config-prettier": "1.18.0",
+    "tslint-no-focused-test": "^0.5.0",
     "typescript": "^3.4.1",
     "uuid": "^3.3.2",
-    "webpack": "^4.29.6"
-  },
-  "devDependencies": {
+    "webpack": "^4.29.6",
     "cypress-cucumber-preprocessor": "1.11.0",
     "cypress-testing-library": "2.4.0",
     "npm-run-all": "4.1.5",
@@ -44,5 +52,17 @@
   },
   "cypress-cucumber-preprocessor": {
     "nonGlobalStepDefinitions": false
+  },
+  "lint-staged": {
+    "src/**/*.ts": [
+      "prettier --write",
+      "tslint --fix",
+      "git add"
+    ]
+  },
+  "husky": {
+    "hooks": {
+      "pre-commit": "lint-staged"
+    }
   }
 }