common: fix task leak in timer (#4831)

isluckys · web-flow · commit cb1afb33e68c · 2025-06-23T08:47:27.000-04:00
signal包里面SetTimeout方法并发时可能会出现task close以后执行start导致泄露
diff --git a/common/signal/timer.go b/common/signal/timer.go
@@ -67,9 +67,9 @@ func (t *ActivityTimer) SetTimeout(timeout time.Duration) {
 		t.checkTask.Close()
 	}
 	t.checkTask = checkTask
-	t.Unlock()
 	t.Update()
 	common.Must(checkTask.Start())
+	t.Unlock()
 }
 
 func CancelAfterInactivity(ctx context.Context, cancel context.CancelFunc, timeout time.Duration) *ActivityTimer {

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,9 @@ func (t *ActivityTimer) SetTimeout(timeout time.Duration) {`
`67`	`67`	`t.checkTask.Close()`
`68`	`68`	`}`
`69`	`69`	`t.checkTask = checkTask`
`70`		`- t.Unlock()`
`71`	`70`	`t.Update()`
`72`	`71`	`common.Must(checkTask.Start())`
	`72`	`+ t.Unlock()`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`func CancelAfterInactivity(ctx context.Context, cancel context.CancelFunc, timeout time.Duration) *ActivityTimer {`