Additional validations+tests for MPTokenIssuanceCreate transaction

Author: ckeshava

packages/xrpl/src/models/transactions/MPTokenIssuanceCreate.ts

@@ -1,5 +1,5 @@
 import { ValidationError } from '../../errors'
-import { isHex, INTEGER_SANITY_CHECK, isFlagEnabled } from '../utils'
+import { isHex, INTEGER_SANITY_CHECK, isFlagEnabled, hasFlag } from '../utils'
 
 import {
   BaseTransaction,
@@ -11,6 +11,7 @@ import {
   MAX_MPT_META_BYTE_LENGTH,
   MPT_META_WARNING_HEADER,
   validateMPTokenMetadata,
+  isDomainID,
 } from './common'
 import type { TransactionMetadataBase } from './metadata'
 
@@ -227,6 +228,7 @@ export interface MPTokenIssuanceCreate extends BaseTransaction {
 
   Flags?: number | MPTokenIssuanceCreateFlagsInterface
   MutableFlags?: number
+  DomainID?: string
 }
 
 export interface MPTokenIssuanceCreateMetadata extends TransactionMetadataBase {
@@ -249,6 +251,20 @@ export function validateMPTokenIssuanceCreate(
   validateOptionalField(tx, 'TransferFee', isNumber)
   validateOptionalField(tx, 'AssetScale', isNumber)
   validateOptionalField(tx, 'MutableFlags', isNumber)
+  validateOptionalField(tx, 'DomainID', isDomainID)
+
+  if (
+    tx.DomainID != null &&
+    !hasFlag(
+      tx,
+      MPTokenIssuanceCreateFlags.tfMPTRequireAuth,
+      'tfMPTRequireAuth',
+    )
+  ) {
+    throw new ValidationError(
+      'MPTokenIssuanceCreate: Cannot set DomainID unless tfMPTRequireAuth flag is set.',
+    )
+  }
 
   if (
     tx.MutableFlags != null &&
@@ -275,7 +291,7 @@ export function validateMPTokenIssuanceCreate(
       throw new ValidationError('MPTokenIssuanceCreate: Invalid MaximumAmount')
     } else if (
       BigInt(tx.MaximumAmount) > BigInt(MAX_AMT) ||
-      BigInt(tx.MaximumAmount) < BigInt(`0`)
+      BigInt(tx.MaximumAmount) <= BigInt(`0`)
     ) {
       throw new ValidationError(
         'MPTokenIssuanceCreate: MaximumAmount out of range',

packages/xrpl/src/models/transactions/common.ts

@@ -774,7 +774,8 @@ export function isDomainID(domainID: unknown): domainID is string {
   return (
     isString(domainID) &&
     domainID.length === _DOMAIN_ID_LENGTH &&
-    isHex(domainID)
+    isHex(domainID) &&
+    domainID !== '0'.repeat(_DOMAIN_ID_LENGTH)
   )
 }
 

packages/xrpl/test/models/MPTokenIssuanceCreate.test.ts

@@ -158,6 +158,50 @@ describe('MPTokenIssuanceCreate', function () {
 
     assertInvalid(invalid, 'MPTokenIssuanceCreate: Invalid MutableFlags value')
   })
+
+  it(`throws with Zero MaximumAmount`, function () {
+    const invalid = {
+      TransactionType: 'MPTokenIssuanceCreate',
+      Account: 'rWYkbWkCeg8dP6rXALnjgZSjjLyih5NXm',
+      MaximumAmount: '0',
+    } as any
+
+    assertInvalid(invalid, 'MPTokenIssuanceCreate: MaximumAmount out of range')
+  })
+
+  it(`throws with Zero DomainID`, function () {
+    const invalid = {
+      TransactionType: 'MPTokenIssuanceCreate',
+      Account: 'rWYkbWkCeg8dP6rXALnjgZSjjLyih5NXm',
+      DomainID: '0'.repeat(64),
+    } as any
+
+    assertInvalid(invalid, 'MPTokenIssuanceCreate: invalid field DomainID')
+  })
+
+  it(`throws with DomainID and tfMPTRequireAuth flag not set`, function () {
+    const invalid = {
+      TransactionType: 'MPTokenIssuanceCreate',
+      Account: 'rWYkbWkCeg8dP6rXALnjgZSjjLyih5NXm',
+      DomainID: '1'.repeat(64),
+      Flags: 0,
+    } as any
+
+    assertInvalid(
+      invalid,
+      'MPTokenIssuanceCreate: Cannot set DomainID unless tfMPTRequireAuth flag is set.',
+    )
+  })
+
+  it(`throws with invalid type of DomainID`, function () {
+    const invalid = {
+      TransactionType: 'MPTokenIssuanceCreate',
+      Account: 'rWYkbWkCeg8dP6rXALnjgZSjjLyih5NXm',
+      DomainID: 1,
+    } as any
+
+    assertInvalid(invalid, 'MPTokenIssuanceCreate: invalid field DomainID')
+  })
 })
 
 /**