add hex validation for data field

Author: ckeshava

tests/unit/core/binarycodec/types/test_blob.py

@@ -17,3 +17,7 @@ def test_from_value(self):
     def test_raises_invalid_value_type(self):
         invalid_value = [1, 2, 3]
         self.assertRaises(XRPLBinaryCodecException, Blob.from_value, invalid_value)
+
+    def test_raises_invalid_non_hex_input(self):
+        invalid_value = "Z"
+        self.assertRaises(ValueError, Blob.from_value, invalid_value)

tests/unit/models/transactions/test_loan_broker_set.py

@@ -14,13 +14,25 @@ def test_invalid_data_too_long(self):
             LoanBrokerSet(
                 account=_SOURCE,
                 vault_id=_VAULT_ID,
-                data="A" * 257,
+                data="A" * 257 * 2,
             )
         self.assertEqual(
             error.exception.args[0],
             "{'LoanBrokerSet:data': 'Data must be less than 256 bytes.'}",
         )
 
+    def test_invalid_data_non_hex_string(self):
+        with self.assertRaises(XRPLModelException) as error:
+            LoanBrokerSet(
+                account=_SOURCE,
+                vault_id=_VAULT_ID,
+                data="Z",
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'LoanBrokerSet:data': 'Data must be a valid hex string.'}",
+        )
+
     def test_invalid_management_fee_rate_too_low(self):
         with self.assertRaises(XRPLModelException) as error:
             LoanBrokerSet(

tests/unit/models/transactions/test_loan_set.py

@@ -16,11 +16,25 @@ def test_invalid_data_too_long(self):
                 loan_broker_id=_ISSUER,
                 principal_requested="100000000",
                 start_date=int(datetime.datetime.now().timestamp()),
-                data="A" * 257,
+                data="A" * 257 * 2,
             )
         self.assertEqual(
             error.exception.args[0],
-            "{'LoanSet:data': 'Data must be less than 512 bytes.'}",
+            "{'LoanSet:data': 'Data must be less than 256 bytes.'}",
+        )
+
+    def test_invalid_data_non_hex_string(self):
+        with self.assertRaises(XRPLModelException) as error:
+            LoanSet(
+                account=_SOURCE,
+                loan_broker_id=_ISSUER,
+                principal_requested="100000000",
+                start_date=int(datetime.datetime.now().timestamp()),
+                data="Z",
+            )
+        self.assertEqual(
+            error.exception.args[0],
+            "{'LoanSet:data': 'Data must be a valid hex string.'}",
         )
 
     def test_invalid_overpayment_fee_too_low(self):

xrpl/models/transactions/loan_broker_set.py

@@ -7,6 +7,7 @@
 
 from typing_extensions import Self
 
+from xrpl.constants import HEX_REGEX
 from xrpl.models.required import REQUIRED
 from xrpl.models.transactions.transaction import Transaction
 from xrpl.models.transactions.types import TransactionType
@@ -63,7 +64,7 @@ class LoanBrokerSet(Transaction):
         init=False,
     )
 
-    MAX_DATA_PAYLOAD_LENGTH = 256
+    MAX_DATA_PAYLOAD_LENGTH = 256 * 2
     MAX_MANAGEMENT_FEE_RATE = 10_000
     MAX_COVER_RATE_MINIMUM = 100_000
     MAX_COVER_RATE_LIQUIDATION = 100_000
@@ -75,6 +76,9 @@ def _get_errors(self: Self) -> Dict[str, str]:
         if self.data is not None and len(self.data) > self.MAX_DATA_PAYLOAD_LENGTH:
             errors["LoanBrokerSet:data"] = "Data must be less than 256 bytes."
 
+        if self.data is not None and not HEX_REGEX.fullmatch(self.data):
+            errors["LoanBrokerSet:data"] = "Data must be a valid hex string."
+
         if self.management_fee_rate is not None and (
             self.management_fee_rate < 0
             or self.management_fee_rate > self.MAX_MANAGEMENT_FEE_RATE

xrpl/models/transactions/loan_set.py

@@ -8,6 +8,7 @@
 
 from typing_extensions import Self
 
+from xrpl.constants import HEX_REGEX
 from xrpl.models.base_model import BaseModel
 from xrpl.models.required import REQUIRED
 from xrpl.models.transactions.transaction import (
@@ -155,7 +156,7 @@ class LoanSet(Transaction):
         init=False,
     )
 
-    MAX_DATA_LENGTH = 256
+    MAX_DATA_LENGTH = 256 * 2
     MAX_OVER_PAYMENT_FEE_RATE = 100_000
     MAX_INTEREST_RATE = 100_000
     MAX_LATE_INTEREST_RATE = 100_000
@@ -173,7 +174,10 @@ def _get_errors(self: Self) -> Dict[str, str]:
         }
 
         if self.data is not None and len(self.data) > self.MAX_DATA_LENGTH:
-            parent_class_errors["LoanSet:data"] = "Data must be less than 512 bytes."
+            parent_class_errors["LoanSet:data"] = "Data must be less than 256 bytes."
+
+        if self.data is not None and not HEX_REGEX.fullmatch(self.data):
+            parent_class_errors["LoanSet:data"] = "Data must be a valid hex string."
 
         if self.overpayment_fee is not None and (
             self.overpayment_fee < 0