Skip to content

Commit 7a6eec8

Browse files
Address feedback
1 parent d47eb79 commit 7a6eec8

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

doc/null_safety/null_safe_migration.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ dart pub global run over_react_codemod:null_safety_migrator_companion --yes-to-a
5252

5353
This codemod will:
5454
- Add nullability hints to state mixin/class fields
55-
- These hints will cause defaulted/initialized values to be migrated as "late required".
55+
- These hints will cause defaulted/initialized values to be migrated as "late required" (the same thing is done for props in the [required props codemod](#required-props-codemod)).
5656
See our [prop requiredness and nullability](#prop-requiredness-and-nullability) docs for more details on whether you should keep them required following the migration.
5757
- All non-initialized state fields will have optional nullable hints.
5858
- Add nullable hints for callback ref types.
@@ -66,7 +66,9 @@ as a separate commit before proceeding with the rest of the migration.
6666
This is a two-step process involving two sub-commands:
6767

6868
1. `null_safety_required_props collect` - Collects requiredness data for all OverReact props based on usages in the specified packages and all their transitive dependencies.
69-
1. `null_safety_required_props codemod` - Adds null safety migrator hints to OverReact props using prop requiredness data from 'collect' command.
69+
1. `null_safety_required_props codemod` - Adds null safety migrator hints to OverReact props taking into account:
70+
1. Prop requiredness data from the 'collect' command.
71+
1. If the prop has a default in `defaultProps`, it will get "late required" hints.
7072

7173
Start with the `collect` command, following its help output for instructions:
7274
```shell

0 commit comments

Comments
 (0)