Skip to content

Commit e3450ca

Browse files
authored
[Parser] Condense redundant pop values (#6339)
A bit of clean-up, changes getBranchValue to use pop().
1 parent dabfd5b commit e3450ca

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

src/wasm/wasm-ir-builder.cpp

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -416,19 +416,7 @@ Result<Expression*> IRBuilder::getBranchValue(Name labelName,
416416
// Loops would receive their input type rather than their output type, if we
417417
// supported that.
418418
size_t numValues = (*scope)->getLoop() ? 0 : (*scope)->getResultType().size();
419-
std::vector<Expression*> values(numValues);
420-
for (size_t i = 0; i < numValues; ++i) {
421-
auto val = pop();
422-
CHECK_ERR(val);
423-
values[numValues - 1 - i] = *val;
424-
}
425-
if (numValues == 0) {
426-
return nullptr;
427-
} else if (numValues == 1) {
428-
return values[0];
429-
} else {
430-
return builder.makeTupleMake(values);
431-
}
419+
return numValues == 0 ? nullptr : pop(numValues);
432420
}
433421

434422
Result<> IRBuilder::visitBreak(Break* curr, std::optional<Index> label) {

0 commit comments

Comments
 (0)