Move HttpUtility to System in unityjit. #1420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves HttpUtility and a few helpers from System.Web to the System assembly. The reduces the dependencies of netstandard.dll greatly. This makes it easier for us to enable Mono players to always use the
unityjitprofile even with API compatibility level of ".NET Standard 2.0". The build size will increase slightly, but much less than without this PR. For example, we have a test today where netstandard.dll pulls in the following extra assemblies when targeting unityjit rather than unityaotTrunk:
With this PR:
Which I think is acceptable.
A type forwarder is setup to not break compatibility. Note, there are two small changes in behavior. The defines in
HttpEncoder.csandHttpUtility.cshardcode some things rather than using System.Configuration. I think this is okay as we already do this in theunityaotprofile.