Skip to content

UnityTls server no longer throws an exception if there is no client cert during client authentication #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018
Merged

UnityTls server no longer throws an exception if there is no client cert during client authentication #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions mcs/class/System/Mono.UnityTls/UnityTlsContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,18 +304,17 @@ public override bool ProcessHandshake ()
if (lastException != null)
throw lastException;

// Not done is not an error if we are server and don't ask for ClientCertificate
if (result == UnityTls.unitytls_x509verify_result.UNITYTLS_X509VERIFY_NOT_DONE && IsServer && !AskForClientCertificate)
// Not done is only an error if we are a client. Even servers with AskForClientCertificate should ignore it since .Net client authentification is always optional.
if (IsServer && result == UnityTls.unitytls_x509verify_result.UNITYTLS_X509VERIFY_NOT_DONE) {
Unity.Debug.CheckAndThrow (errorState, "Handshake failed", AlertDescription.HandshakeFailure);
else
Unity.Debug.CheckAndThrow (errorState, result, "Handshake failed", AlertDescription.HandshakeFailure);

// .Net implementation gives the server a verification callback (with null cert) even if AskForClientCertificate is false.
// We stick to this behavior here.
if (IsServer && !AskForClientCertificate) {

// .Net implementation gives the server a verification callback (with null cert) even if AskForClientCertificate is false.
// We stick to this behavior here.
if (!ValidateCertificate (null, null))
throw new TlsException (AlertDescription.HandshakeFailure, "Verification failure during handshake");
}
else
Unity.Debug.CheckAndThrow (errorState, result, "Handshake failed", AlertDescription.HandshakeFailure);

return true;
}
Expand Down