[refactor] Allow full RunOptions to be specified in trainer configuration YAML #3815
+162
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
April 13, 2020 18:47
… develop-single-config
… develop-single-config
ervteng
commented
Apr 21, 2020
added 2 commits
April 20, 2020 23:22
harperj
reviewed
Apr 22, 2020
harperj
reviewed
Apr 22, 2020
10 tasks
added 5 commits
April 23, 2020 15:09
harperj
reviewed
Apr 29, 2020
added 7 commits
April 29, 2020 12:26
Move CLI options back to learn.py
harperj
approved these changes
Apr 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Rather than have the YAML stored as part of RunOptions, make the YAML a representation of RunOptions, including engine options and other parameters. Anything not specified in the YAML config will be set to the default values; anything specified in the CLI will override values found in the YAML.
This removes the need for a separate run_experiment entry point.
Types of change(s)
Checklist
Other comments