Add SensorShapeValidator unit #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 25, 2020 16:49
chriselion
changed the title
chriselion
commented
Feb 26, 2020
| // TODO make sure this only checks once per agent | ||
| Debug.Assert(m_SensorShapes.Count == sensors.Count, $"Number of Sensors must match. {m_SensorShapes.Count} != {sensors.Count}"); | ||
| for (var i = 0; i < m_SensorShapes.Count; i++) | ||
| for (var i = 0; i < Mathf.Min(m_SensorShapes.Count, sensors.Count); i++) |
Contributor
Author
There was a problem hiding this comment.
If these differed before, we'd get the assert, but would potentially continue and iterate through the lists, so accessing sensors[i] would read past the end of the list.
chriselion
commented
Feb 26, 2020
| string m_Name = "NoopSensor"; | ||
| int[] m_Shape; | ||
|
|
||
| public NoopSensor(int dim1) |
Contributor
Author
There was a problem hiding this comment.
Just some convenience methods for making sensors of a certain size.
vincentpierre
approved these changes
Feb 27, 2020
|
|
||
| namespace MLAgents.Tests | ||
| { | ||
| public class NoopSensor : ISensor |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I can rename to DummySensor or something clearer
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add unit tests for SensorShapeValidator, fix potential errors.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments