Skip to content

Commit 3a7815d

Browse files
pxrlmrice32
andauthored
Apply suggestions from code review
Co-authored-by: Matt Rice <[email protected]>
1 parent c4005ee commit 3a7815d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

UMIPs/umip-179.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The `V3RelayData` type underpins the transfer of funds in or out of a SpokePool
5959
| message | bytes | Optional data that is forwarded to the recipient as part of a relay. |
6060

6161
#### Note
62-
- `V3RelayData` specifies `bytes32` representation for addresses (`depositor`, `recipient`, ...) in order to interface with non-EVM chains. EVM addressed supplied shall be promoted to type `bytes32` with the upper 12 bytes zeroed.
62+
- `V3RelayData` specifies `bytes32` representation for addresses (`depositor`, `recipient`, ...) in order to interface with non-EVM chains. The EVM address supplied shall be promoted to type `bytes32` with the upper 12 bytes zeroed.
6363

6464
### V3RelayDataLegacy
6565
The `V3RelayDataLegacy` type is supported for backwards compatibility, but is slated for deprecation. `V3RelayDataLegacy` has the following delta to the `V3RelayData` type:
@@ -348,16 +348,15 @@ For each of the `Deposits` emitted within the `Bundle Block Range` where no corr
348348
3. Verify that the `Fill` occurred prior to the current the `Bundle Block Range` on the destination chain SpokePool.
349349

350350
#### Note
351-
- No specific method is prescribed for resolving the fill on the destination chain. An `eth_getLogs` request can facilitate this, and if required, the `Bundle Block Range` could be narrowed by a binary search over the `FillStatus` field. This is left as an implementation decision.
351+
- No specific method is prescribed for resolving the `Fill` on the destination chain. An `eth_getLogs` request can facilitate this, and if required, the `Bundle Block Range` could be narrowed by a binary search over the `FillStatus` field. This is left as an implementation decision.
352352

353353
### Finding Expired Deposits
354354
For the purpose of computing depositor refunds, each `Deposit` shall be considered expired by verifying that:
355355
1. The `fillDeadline` timestamp elapsed within the `Bundle Block Range` on the destination SpokePool (i.e. the `fillDeadline` expired between the `block.timestamp` of the destination chain's bundle start and end block),
356-
2. The `FillStatus` on the destination SpokePool is set to `Unfilled` or `SlowFillRequested`.
356+
2. The `FillStatus` on the destination SpokePool is set to `Unfilled` or `SlowFillRequested` as at the end of the `Bundle Block Range`.
357357

358358
#### Note
359359
- Expired deposits shall be refunded to the `depositor` address on the origin SpokePool.
360-
- If the `depositor` address is not valid on the `originChainId`, the deposit refund shall be discarded.
361360
- Depositor refunds are to be issued as part of the relayer refund procedure.
362361
- The `fillDeadline` timestamp shall be resolved to a block number on the destination chain in order to determine inclusion within the `Bundle Block Range`.
363362

@@ -378,7 +377,7 @@ For the purpose of computing slow fills to be issued to recipients, each `Slow F
378377
When an early `Slow Fill Request` is implied, the `Slow Fill Request` shall be validated as follows:
379378
1. The `fillDeadline` has not already elapsed relative to the `destinationChainId` bundle end block number,
380379
2. The `inputToken` and `outputToken` addresses are equivalent at the deposit `quoteTimestamp`,
381-
3. The `originChainId` and `destinationChainId` are not Lite chains.
380+
3. Neither the`originChainId` nor the `destinationChainId` is a `Lite` chain.
382381

383382
#### Note
384383
- An early `Slow Fill Request` is implied where a `Deposit` emitted within the current `Bundle Block Range` has a `FillStatus` of `SlowFillRequested` as at the end of the current `Bundle Block Range` on the destination chain, but where no `Slow Fill Request` is identified within the current `Bundle Block Range`. This may occur where the `Slow Fill Request` was submitted prior to the current bundle.

0 commit comments

Comments
 (0)