BUG: Fix Bug When OME-TIFF Missing Objective Power #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last if statment would cause overwriting of metadata for an OME-TIFF.
Codecov Report
@@ Coverage Diff @@
## develop #492 +/- ##
========================================
Coverage 99.63% 99.63%
========================================
Files 61 61
Lines 6232 6240 +8
Branches 1035 1035
========================================
+ Hits 6209 6217 +8
Misses 10 10
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaneahmed
reviewed
Oct 20, 2022
shaneahmed
reviewed
Oct 20, 2022
Member
shaneahmed
left a comment
shaneahmed
left a comment
There was a problem hiding this comment.
Just one minor comment.
Please can you also check coverage.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 6bf91f0.
When using TIFFReader with a generic TIFF, fetching resolution tags now works even if the TIFF is not tiled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code for parsing OME-TIFF metadata and fixed a bug where an exception would be raised if the OME XML is missing objective power. This was noticeable when there was MPP data but not objective power such as with file created by tifffile.
To-Do