Skip to content

DEV: Add docs/requirements.txt to requirements_dev.txt #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2022
Merged

DEV: Add docs/requirements.txt to requirements_dev.txt #470

merged 3 commits into from
Sep 13, 2022

Conversation

@shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Sep 12, 2022

  • Add docs/requirements.txt to requirements_dev.txt

@shaneahmed
DEV: Add docs/requirements.txt to requirements_dev.txt.
565da14 
- Add `docs/requirements.txt` to `requirements_dev.txt`.

Signed-off-by: Shan E Ahmed Raza <[email protected]>
@shaneahmed
DEV: Update GitHub workflow
8e37be3 
- Update GitHub workflow
@shaneahmed
DEV: Add command mkdir /tmp/docs/
761a2b9 
- Add command mkdir /tmp/docs/
@codecov
Copy link

codecov bot commented Sep 12, 2022 •
edited
Loading

Codecov Report

Merging #470 (761a2b9) into develop (89f95c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #470   +/-   ##
========================================
  Coverage    98.63%   98.63%           
========================================
  Files           62       62           
  Lines         5937     5937           
  Branches      1056     1056           
========================================
  Hits          5856     5856           
  Misses          69       69           
  Partials        12       12

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed shaneahmed added dev tools Changes/Updates in Development tools dependencies Pull requests that update a dependency file labels Sep 12, 2022
@shaneahmed shaneahmed self-assigned this Sep 12, 2022
DavidBAEpstein
DavidBAEpstein reviewed Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@DavidBAEpstein DavidBAEpstein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the same change has not been made to requirements.dev.conda.yml?
OK, looking a second time, it seems that this is not necessary.

@DavidBAEpstein DavidBAEpstein self-requested a review September 13, 2022 14:30
DavidBAEpstein
DavidBAEpstein approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@DavidBAEpstein DavidBAEpstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A definite improvement. The workflow on a Mac to install tiatoolbox-dev worked without a hitch.

@shaneahmed shaneahmed merged commit 8b7855d into develop Sep 13, 2022
@shaneahmed shaneahmed deleted the dev-add-doc-dep-requirements-dev branch September 13, 2022 23:04
@shaneahmed shaneahmed restored the dev-add-doc-dep-requirements-dev branch September 23, 2022 09:52
shaneahmed added a commit that referenced this pull request Sep 23, 2022
@shaneahmed
Revert "DEV: Add docs/requirements.txt to requirements_dev.txt (#470
80a271b 
)"

This reverts commit 8b7855d.
@shaneahmed shaneahmed mentioned this pull request Sep 23, 2022
Closed
@shaneahmed shaneahmed deleted the dev-add-doc-dep-requirements-dev branch September 23, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBAEpstein DavidBAEpstein DavidBAEpstein approved these changes

Assignees

@shaneahmed shaneahmed

Labels

dependencies Pull requests that update a dependency file dev tools Changes/Updates in Development tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaneahmed @DavidBAEpstein