Skip to content

DEV: Use requirements.txt in setup.py #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 23, 2022
Merged

DEV: Use requirements.txt in setup.py #467

merged 8 commits into from
Sep 23, 2022

Conversation

@shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Sep 12, 2022 •
edited
Loading

  • Use requirements.txt in setup.py

@shaneahmed
DEV: Use requirements.txt in setup.py
7e9f2ad 
- Use requirements.txt in setup.py

Signed-off-by: Shan E Ahmed Raza <[email protected]>
@shaneahmed
DEV: Copy requirements.txt in GitHub workflow
41df20d 
- Copy requirements.txt in GitHub workflow
@codecov
Copy link

codecov bot commented Sep 12, 2022 •
edited
Loading

Codecov Report

Merging #467 (26c3078) into develop (419d7bb) will not change coverage.
The diff coverage is n/a.

❗ Current head 26c3078 differs from pull request most recent head b8ba636. Consider uploading reports for the commit b8ba636 to get more accurate results

@@           Coverage Diff            @@
##           develop     #467   +/-   ##
========================================
  Coverage    99.64%   99.64%           
========================================
  Files           62       62           
  Lines         5952     5952           
  Branches      1058     1058           
========================================
  Hits          5931     5931           
  Misses           9        9           
  Partials        12       12

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed
DEV: Add pytorch cu113 link
2335c1e 
- Add pytorch cu113 link
@shaneahmed
DEV: Add pytorch cu113 link
9ef74cd 
- Add pytorch cu113 link
@shaneahmed shaneahmed requested a review from John-P September 12, 2022 13:49
@shaneahmed
DEV: Update requirements_dev file
7fc92db 
- Update requirements_dev file
@shaneahmed
REV: Revert requirements_dev changes
e750285 
- Revert requirements_dev changes
@shaneahmed shaneahmed added the dependencies Pull requests that update a dependency file label Sep 12, 2022
@shaneahmed shaneahmed self-assigned this Sep 12, 2022
John-P
John-P reviewed Sep 23, 2022
View reviewed changes
@shaneahmed shaneahmed merged commit 1757f84 into develop Sep 23, 2022
@shaneahmed shaneahmed deleted the dev-use-requirements-for-setup.py branch September 23, 2022 09:44
@shaneahmed shaneahmed restored the dev-use-requirements-for-setup.py branch September 23, 2022 09:53
@shaneahmed shaneahmed deleted the dev-use-requirements-for-setup.py branch September 23, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@John-P John-P John-P approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shaneahmed shaneahmed

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaneahmed @John-P