Skip to content

Conversation

@vqdang
Copy link
Contributor

@vqdang vqdang commented Dec 20, 2021

Rename:

  • FeatureExtractor to DeepFeatureExtractor
  • CNNExtractor to CNNBackbone

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

- Fix requirements_dev.txt for python 3.7
…es-and-functions

# Conflicts:
#	requirements_dev.txt
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #226 (769a4bc) into develop (96ea2b1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #226   +/-   ##
========================================
  Coverage    99.81%   99.81%           
========================================
  Files           53       53           
  Lines         4867     4867           
  Branches       800      800           
========================================
  Hits          4858     4858           
  Misses           2        2           
  Partials         7        7           
Impacted Files Coverage Δ
tiatoolbox/models/__init__.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/__init__.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/vanilla.py 100.00% <100.00%> (ø)
tiatoolbox/models/engine/semantic_segmentor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ea2b1...769a4bc. Read the comment docs.

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vqdang

@shaneahmed shaneahmed merged commit c56b5dc into develop Dec 21, 2021
@shaneahmed shaneahmed deleted the dev-renaming-classes-and-functions branch December 21, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants