Skip to content

Commit 7fc4937

Browse files
committed
Changed after reviews of .cpp files
1 parent 22d6f06 commit 7fc4937

File tree

4 files changed

+1
-11
lines changed

4 files changed

+1
-11
lines changed

src/empole_chgpen_acc.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ namespace tinker {
1313
#define DEVICE_PTRS \
1414
x, y, z, demx, demy, demz, rpole, pcore, pval, palpha, pot, nem, em, \
1515
vir_em, trqx, trqy, trqz
16-
// TODO: HIPPO not reviewed
1716
template <class Ver, class ETYP, bool CFLX>
1817
void empole_chgpen_acc1()
1918
{
@@ -414,7 +413,6 @@ void empole_generic_ewald_recip_acc()
414413
}
415414

416415

417-
// TODO: HIPPO not reviewed
418416
void empole_chgpen_nonewald_acc(int vers, int use_cf)
419417
{
420418
if (use_cf) {
@@ -451,7 +449,6 @@ void empole_chgpen_nonewald_acc(int vers, int use_cf)
451449
}
452450

453451

454-
// TODO: HIPPO not reviewed
455452
void empole_chgpen_ewald_real_self_acc(int vers, int use_cf)
456453
{
457454
if (use_cf) {

src/epolar_chgpen_acc.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace tinker {
1414
#define POLAR_DPTRS \
1515
x, y, z, depx, depy, depz, rpole, pcore, pval, palpha, pot, uind, nep, ep, \
1616
vir_ep, ufld, dufld
17-
// TODO: HIPPO not reviewed
1817
template <class Ver, class ETYP, bool CFLX>
1918
void epolar_chgpen_acc1(const real (*uind)[3])
2019
{
@@ -667,7 +666,6 @@ void epolar_chgpen_ewald_recip_self_acc1(const real (*gpu_uind)[3])
667666
}
668667

669668

670-
// TODO: HIPPO not reviewed
671669
void epolar_chgpen_nonewald_acc(int vers, int use_cf, const real (*uind)[3])
672670
{
673671
if (use_cf) {

src/field_chgpen_acc.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
namespace tinker {
1414
// see also subroutine udirect2b / dfield_chgpen0c in induce.f
1515
#define DFIELD_DPTRS x, y, z, pcore, pval, palpha, field, rpole
16-
// TODO: HIPPO not reviewed
1716
template <class ETYP>
1817
void dfield_chgpen_acc1(real (*field)[3])
1918
{
@@ -198,7 +197,6 @@ void ufield_chgpen_ewald_recip_self_acc(const real (*uind)[3], real (*field)[3])
198197
}
199198

200199
#define UFIELD_DPTRS x, y, z, pcore, pval, palpha, field, uind
201-
// TODO: HIPPO not reviewed
202200
template <class ETYP>
203201
void ufield_chgpen_acc1(const real (*uind)[3], real (*field)[3])
204202
{

src/induce_donly_acc.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include <tinker/detail/units.hh>
1919

2020
namespace tinker {
21-
// TODO: HIPPO not reviewed
2221
void diag_precond2(const real (*rsd)[3], real (*zrsd)[3])
2322
{
2423
#pragma acc parallel loop independent async\
@@ -32,7 +31,6 @@ void diag_precond2(const real (*rsd)[3], real (*zrsd)[3])
3231
}
3332

3433
#define APPLY_DPTRS rsd, zrsd, x, y, z, polarity, palpha
35-
// TODO: HIPPO not reviewed
3634
void sparse_precond_apply2_acc(const real (*rsd)[3], real (*zrsd)[3])
3735
{
3836
#pragma acc parallel loop independent async\
@@ -183,7 +181,6 @@ void sparse_precond_apply2_acc(const real (*rsd)[3], real (*zrsd)[3])
183181
* conj = p
184182
* vec = T P
185183
*/
186-
// TODO: HIPPO not reviewed
187184
void induce_mutual_pcg2_acc(real (*uind)[3])
188185
{
189186
auto* field = work01_;
@@ -340,7 +337,7 @@ void induce_mutual_pcg2_acc(real (*uind)[3])
340337

341338
// calculate/update p
342339
#pragma acc parallel loop independent async\
343-
deviceptr(conj,zrsd,rsd)
340+
deviceptr(conj,zrsd)
344341
for (int i = 0; i < n; ++i) {
345342
#pragma acc loop seq
346343
for (int j = 0; j < 3; ++j)

0 commit comments

Comments
 (0)