Skip to content

Commit d84ea26

Browse files
authored
Fix numpy.sum overflow in aggregate tests (#2245)
1 parent feb8cef commit d84ea26

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tiledb/tests/test_aggregates.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ def get_test_data(dtype, use_corner_cases, size=10):
8787
assert max_result == max(expected)
8888

8989
# For sum and mean, handle corner cases differently
90-
expected_sum = np.sum(expected)
91-
expected_mean = np.sum(expected) / len(expected)
90+
expected_sum = sum(int(x) for x in expected)
91+
expected_mean = expected_sum / len(expected)
9292

9393
assert sum_result == expected_sum
9494
assert mean_result == expected_mean
@@ -123,8 +123,11 @@ def get_test_data(dtype, use_corner_cases, size=10):
123123
assert sub_count == len(expected_sub)
124124
assert sub_min == min(expected_sub)
125125
assert sub_max == max(expected_sub)
126-
assert sub_sum == np.sum(expected_sub)
127-
assert sub_mean == np.sum(expected_sub) / len(expected_sub)
126+
127+
expected_sub_sum = sum(int(x) for x in expected_sub)
128+
expected_sub_mean = expected_sub_sum / len(expected_sub)
129+
assert sub_sum == expected_sub_sum
130+
assert sub_mean == expected_sub_mean
128131

129132
assert q.agg({"a": "sum"})[4:7] == sub_sum
130133
assert q.agg({"a": "min"})[4:7] == sub_min

0 commit comments

Comments
 (0)