Skip to content

Commit 6545867

Browse files
fix: allign DC breadcrumb navigation bar (#3868)
fix #3204
1 parent 513be62 commit 6545867

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

client/src/features/dataConnectorsV2/components/DataConnectorModal/DataConnectorModalFooter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ function DataConnectorCreateFooter({
345345
<RtkOrNotebooksError error={actionError} />
346346
</div>
347347
)}
348-
<div className={cx("d-flex", "flex-grow-1")}>
348+
<div className={cx("d-flex", "me-auto", "my-auto")}>
349349
<AddStorageBreadcrumbNavbar
350350
state={cloudStorageState}
351351
setState={setStateSafe}

client/src/features/project/components/cloudStorage/AddStorageBreadcrumbNavbar.tsx

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import cx from "classnames";
2020
import { useMemo } from "react";
21-
import { Breadcrumb, BreadcrumbItem, Button } from "reactstrap";
21+
import { BreadcrumbItem, Button } from "reactstrap";
2222

2323
import { CLOUD_STORAGE_TOTAL_STEPS } from "./projectCloudStorage.constants";
2424
import { AddCloudStorageState } from "./projectCloudStorage.types";
@@ -46,18 +46,19 @@ export default function AddStorageBreadcrumbNavbar({
4646
const active = stepNumber === step;
4747
const disabled = stepNumber > completedSteps + 1;
4848
return (
49-
<BreadcrumbItem active={active} key={stepNumber}>
49+
<BreadcrumbItem
50+
className={cx("d-flex", "my-auto")}
51+
active={active}
52+
key={stepNumber}
53+
>
5054
{active ? (
51-
<span className={cx(active && "fw-bold", "align-self-end")}>
55+
<span className={cx(active && "fw-bold")}>
5256
{mapStepToName[stepNumber]}
5357
</span>
5458
) : (
5559
<>
5660
<Button
57-
className={cx(
58-
"p-0",
59-
(active || disabled) && "text-decoration-none"
60-
)}
61+
className={cx(disabled && "text-decoration-none", "p-0")}
6162
color="link"
6263
disabled={disabled}
6364
onClick={() => {
@@ -75,7 +76,11 @@ export default function AddStorageBreadcrumbNavbar({
7576
}, [completedSteps, setState, step, state.advancedMode]);
7677

7778
return (
78-
<Breadcrumb data-cy="cloud-storage-edit-navigation">{items}</Breadcrumb>
79+
<nav aria-label="breadcrumb" data-cy="cloud-storage-edit-navigation">
80+
<ol className={cx("align-items-center", "breadcrumb", "d-flex", "m-0")}>
81+
{items}
82+
</ol>
83+
</nav>
7984
);
8085
}
8186

0 commit comments

Comments
 (0)