Updating to use eslint 4.x.

Author: adanperez

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## 3.0.0
+- Updated base eslint dependency to 4.0.0
+- Added errors/for-direction rule
+- Added errors/getter-return rule
+- Added node/no-buffer-constructor rule
+- Added style/semi-style rule
+- Added style/switch-colon-spacing rule
+- Removed react/jsx-space-before-closing rule
+
 ## 2.25.0
 - Added react/no-will-update-set-state rule
 - Updated base eslint-plugin-react dependency to 7.0.0

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-config-smartthings",
-	"version": "2.25.0",
+	"version": "3.0.0",
 	"description": "SmartThings's ESLint config",
 	"main": "index.js",
 	"repository": {
@@ -31,7 +31,7 @@
 	},
 	"homepage": "https://github.com/SmartThingsOSS/eslint-config-smartthings",
 	"peerDependencies": {
-		"eslint": "^3.0.0",
+		"eslint": "^4.0.0",
 		"eslint-plugin-react": "^7.0.0"
 	}
 }

rules/errors.js

@@ -1,5 +1,9 @@
 module.exports = {
 	'rules': {
+		// enforce “for” loop update clause moving the counter in the right direction
+		'for-direction': 2,
+		// enforce return statements in getters
+		'getter-return': 2,
 		// Disallow await inside of loops (no-await-in-loop)
 		'no-await-in-loop': 2,
 		// disallow comparing against -0

rules/es6.js

@@ -54,8 +54,6 @@ module.exports = {
 		'prefer-destructuring': 0,
 		// disallow parseInt() in favor of binary, octal, and hexadecimal literals
 		'prefer-numeric-literals': 2,
-		// suggest using Reflect methods where applicable
-		'prefer-reflect': 0,
 		// require rest parameters instead of arguments
 		'prefer-rest-params': 0,
 		// suggest using the spread operator instead of .apply()

rules/node.js

@@ -9,6 +9,8 @@ module.exports = {
 		'global-require': 2,
 		// enforces error handling in callbacks (node environment)
 		'handle-callback-err': 0,
+		// disallow use of the Buffer() constructor
+		'no-buffer-constructor': 2,
 		// disallow mixing regular variable and require declarations
 		'no-mixed-requires': [0, false],
 		// disallow use of new operator with the require function

rules/react.js

@@ -71,8 +71,6 @@ module.exports = {
 		'react/jsx-pascal-case': 2,
 		// Enforce props alphabetical sorting
 		'react/jsx-sort-props': 0,
-		// Validate spacing before closing bracket in JSX
-		'react/jsx-space-before-closing': [2, 'always'],
 		// Validate whitespace in and around the JSX opening and closing brackets
 		'react/jsx-tag-spacing': [2, {
 			'closingSlash': 'never',

rules/style.js

@@ -1,7 +1,11 @@
 module.exports = {
 	'rules': {
+		// enforce line breaks after opening and before closing array brackets
+		'array-bracket-newline': 0,
 		// enforce spacing inside array brackets
 		'array-bracket-spacing': 0,
+		// enforce line breaks after each array element
+		'array-element-newline': 0,
 		// enforce consistent spacing inside single-line blocks
 		'block-spacing': [2, 'always'],
 		// enforce one true brace style
@@ -44,8 +48,6 @@ module.exports = {
 		'line-comment-position': 0,
 		// enforces empty lines around comments
 		'lines-around-comment': 0,
-		// require or disallow newlines around directives
-		'lines-around-directive': 0,
 		// disallow mixed 'LF' and 'CRLF' as linebreaks
 		'linebreak-style': 0,
 		// enforce a maximum depth that blocks can be nested
@@ -68,10 +70,6 @@ module.exports = {
 		'new-cap': [2, { 'newIsCap': true }],
 		// disallow the omission of parentheses when invoking a constructor with no arguments
 		'new-parens': 2,
-		// allow/disallow an empty newline after var statement
-		'newline-after-var': 0,
-		// require newline before return statement
-		'newline-before-return': 0,
 		// disallow use of the Array constructor
 		'no-array-constructor': 2,
 		// disallow bitwise operators
@@ -128,6 +126,8 @@ module.exports = {
 		'operator-linebreak': 0,
 		// enforce padding within blocks
 		'padded-blocks': [2, 'never'],
+		// require or disallow padding lines between statements
+		'padding-line-between-statements': 0,
 		// require quotes around object literal property names
 		'quote-props': 0,
 		// specify whether double or single quotes should be used
@@ -136,10 +136,12 @@ module.exports = {
 		'require-jsdoc': 0,
 		// require identifiers to match the provided regular expression
 		'id-match': 0,
-		// enforce spacing before and after semicolons
-		'semi-spacing': [2, { 'before': false, 'after': true }],
 		// require or disallow use of semicolons instead of ASI
 		'semi': [2, 'always'],
+		// enforce spacing before and after semicolons
+		'semi-spacing': [2, { 'before': false, 'after': true }],
+		// enforce location of semicolons
+		'semi-style': [2, 'last'],
 		// requires object keys to be sorted
 		'sort-keys': 0,
 		// sort variables within the same declaration block
@@ -162,6 +164,8 @@ module.exports = {
 			'exceptions': ['-', '+'],
 			'markers': ['=', '!']           // space here to support sprockets directives
 		}],
+		// enforce spacing around colons of switch statements
+		'switch-colon-spacing': 2,
 		// Require or disallow spacing between template tags and their literals (template-tag-spacing)
 		'template-tag-spacing': [2, 'never'],
 		// require or disallow the Unicode BOM