-
-
Notifications
You must be signed in to change notification settings - Fork 888
Jpeg new IDCT & fused zigzag/transpose steps #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jpeg new IDCT & fused zigzag/transpose steps #1847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
======================================
Coverage 87% 87%
======================================
Files 937 937
Lines 48438 48456 +18
Branches 6057 6058 +1
======================================
+ Hits 42215 42270 +55
+ Misses 5212 5177 -35
+ Partials 1011 1009 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| /// <param name="quantTable">Quantization table to adjust.</param> | ||
| public static void AdjustToIDCT(ref Block8x8F quantTable) | ||
| { | ||
| for (int i = 0; i < Block8x8F.Size; i++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AdjustmentCoefficients is 64 elements yeah? If so, since Block8x8F indexer doesn't do bounds checks in release we could avoid the check here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Did it without indexer with pure Unsafe.Add. We need nint indexer for Block8x8F & Block8x8 IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason we can’t have that now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of places where indexer is used and which can use nint indexer. I'd rather do it as a separate PR. Code cleanup is the last part of my closed decoder optimization PR so I can do it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Makes sense
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Excellent as ever! 👍
Prerequisites
Description
This PR brings 2 new things:
Benchmarks
Master
PR