MockDulwichRepo: mimick git behaviour more closely

When git clones a repo in a base directory, it will place the clone
in a subdirectory of the base. That subdirectory is named after
the repo url name, which is the "testing" right before the .git in
https://github.com/test/testing.git

This behaviour may introduce race conditions to Poetry. Let the
mock repo mimic it, so that the (absence of) race conditions
can be verified.

Author: TheSven73

tests/helpers.py

@@ -113,7 +113,8 @@ def mock_clone(
     if not source_root:
         source_root = Path(Config.create().get("cache-dir")) / "src"
 
-    dest = source_root / path
+    assert parsed.name is not None
+    dest = source_root / parsed.name
     dest.mkdir(parents=True, exist_ok=True)
 
     copy_path(folder, dest)

tests/installation/test_executor.py

@@ -1091,7 +1091,7 @@ def test_executor_should_append_subdirectory_for_git(
     executor.execute([Install(package)])
 
     archive_arg = spy.call_args[0][0]
-    assert archive_arg == tmp_venv.path / "src/demo/subdirectories/two"
+    assert archive_arg == tmp_venv.path / "src/subdirectories/two"
 
 
 def test_executor_should_install_multiple_packages_from_same_git_repository(
@@ -1131,10 +1131,10 @@ def test_executor_should_install_multiple_packages_from_same_git_repository(
     executor.execute([Install(package_a), Install(package_b)])
 
     archive_arg = spy.call_args_list[0][0][0]
-    assert archive_arg == tmp_venv.path / "src/demo/subdirectories/package_a"
+    assert archive_arg == tmp_venv.path / "src/subdirectories/package_a"
 
     archive_arg = spy.call_args_list[1][0][0]
-    assert archive_arg == tmp_venv.path / "src/demo/subdirectories/package_b"
+    assert archive_arg == tmp_venv.path / "src/subdirectories/package_b"
 
 
 @pytest.mark.xfail