Skip to content

Conversation

bzsolt
Copy link
Member

@bzsolt bzsolt commented Aug 3, 2015

Related issue: #511

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]

@ruben-ayrapetyan ruben-ayrapetyan self-assigned this Aug 3, 2015
@zherczeg
Copy link
Member

zherczeg commented Aug 4, 2015

LGTM

@kkristof kkristof added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Aug 4, 2015
@kkristof kkristof added this to the ECMA builtins milestone Aug 4, 2015
@sand1k
Copy link
Contributor

sand1k commented Aug 5, 2015

LGTM.

@ruben-ayrapetyan
Copy link
Contributor

@bzsolt, the change looks good to me.


Seems that there is an issue, not related to current changes in the pull request, but related to Function.prototype.bind: ecma_gc_mark doesn't mark objects that are contained in ECMA_INTERNAL_PROPERTY_BOUND_FUNCTION_BOUND_THIS and ECMA_INTERNAL_PROPERTY_BOUND_FUNCTION_BOUND_ARGS. Because of this, GC can incorrectly consider the objects unreachable and free them.

Maybe, we should raise an issue about this.

Related issue: jerryscript-project#511

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
@bzsolt bzsolt force-pushed the function-prototype-bind-issue-511 branch from 0d1318e to e61f41a Compare August 6, 2015 11:07
@kkristof kkristof merged commit e61f41a into jerryscript-project:master Aug 6, 2015
@bzsolt bzsolt deleted the function-prototype-bind-issue-511 branch August 7, 2015 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants