Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)

huntie · Saadnajmi · commit 5353ca0a775f · 2023-08-22T23:08:52.000-07:00
Summary: Pull Request resolved: facebook#37914 Restores facebook#37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android. Changelog: None Reviewed By: cortinico Differential Revision: D46762984 fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
diff --git a/ReactCommon/jsc/JSCRuntime.cpp b/ReactCommon/jsc/JSCRuntime.cpp
@@ -396,6 +396,13 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)
       stringCounter_(0)
 #endif
 {
+#ifndef NDEBUG
+#ifdef TARGET_OS_MAC
+  if (__builtin_available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {
+    JSGlobalContextSetInspectable(ctx_, true);
+  }
+#endif
+#endif
 }
 
 JSCRuntime::~JSCRuntime() {

Original file line number	Diff line number	Diff line change
`@@ -396,6 +396,13 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)`
`396`	`396`	`stringCounter_(0)`
`397`	`397`	`#endif`
`398`	`398`	`{`
	`399`	`+#ifndef NDEBUG`
	`400`	`+#ifdef TARGET_OS_MAC`
	`401`	`+ if (__builtin_available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {`
	`402`	`+ JSGlobalContextSetInspectable(ctx_, true);`
	`403`	`+ }`
	`404`	`+#endif`
	`405`	`+#endif`
`399`	`406`	`}`
`400`	`407`
`401`	`408`	`JSCRuntime::~JSCRuntime() {`