From 2a0e88d8c00cba49169ed9b18ea91969411d2dc3 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Wed, 3 Nov 2021 13:58:00 -0300 Subject: [PATCH 1/2] changelog + version --- changelog.txt | 3 +++ src/y_code_pal_version.intf.abap | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changelog.txt b/changelog.txt index 01d0c8f4..eb4b9438 100644 --- a/changelog.txt +++ b/changelog.txt @@ -16,6 +16,9 @@ Legend + : added - : removed +2021-11-03 v.1.16.1 +------------------ + 2021-11-01 v.1.16.0 ------------------ * Prefer New: Dynamic Call with Parameters (#502) diff --git a/src/y_code_pal_version.intf.abap b/src/y_code_pal_version.intf.abap index 06d1d8a7..f404bd39 100644 --- a/src/y_code_pal_version.intf.abap +++ b/src/y_code_pal_version.intf.abap @@ -1,3 +1,3 @@ INTERFACE y_code_pal_version PUBLIC. "#EC CONS_INTF - CONSTANTS abap TYPE string VALUE '1.16.0' ##NO_TEXT. + CONSTANTS abap TYPE string VALUE '1.16.1' ##NO_TEXT. ENDINTERFACE. From f9cd107e240e1aa7c0fcfaed4b5134ca3bf30bfb Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Wed, 3 Nov 2021 14:05:17 -0300 Subject: [PATCH 2/2] DB Access in UT: False Positive (#513) * fixing false positive * changelog Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co> --- changelog.txt | 1 + src/checks/y_check_db_access_in_ut.clas.abap | 18 ++++++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/changelog.txt b/changelog.txt index eb4b9438..0a1bac63 100644 --- a/changelog.txt +++ b/changelog.txt @@ -18,6 +18,7 @@ Legend 2021-11-03 v.1.16.1 ------------------ +* DB Access in UT: False Positive (#513) 2021-11-01 v.1.16.0 ------------------ diff --git a/src/checks/y_check_db_access_in_ut.clas.abap b/src/checks/y_check_db_access_in_ut.clas.abap index f136508f..f37ab4d0 100644 --- a/src/checks/y_check_db_access_in_ut.clas.abap +++ b/src/checks/y_check_db_access_in_ut.clas.abap @@ -39,7 +39,8 @@ CLASS y_check_db_access_in_ut DEFINITION PUBLIC INHERITING FROM y_check_base CRE END OF keys. TYPES: BEGIN OF properties, - name TYPE string, + program_name TYPE string, + class_name TYPE string, risk_level TYPE string, has_framework TYPE abap_bool, END OF properties. @@ -128,12 +129,14 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION. METHOD add_line_to_defined_classes. TRY. - DATA(class_config) = VALUE properties( name = get_class_name( structure ) ). + DATA(class_config) = VALUE properties( program_name = program_name + class_name = get_class_name( structure ) ). CATCH cx_sy_itab_line_not_found. RETURN. ENDTRY. - IF line_exists( defined_classes[ name = class_config-name ] ). + IF line_exists( defined_classes[ program_name = program_name + class_name = class_config-class_name ] ). RETURN. ENDIF. @@ -191,7 +194,8 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION. RETURN. ENDIF. - DATA(defined_superclass) = VALUE #( defined_classes[ name = superclass ] OPTIONAL ). + DATA(defined_superclass) = VALUE #( defined_classes[ program_name = program_name + class_name = superclass ] OPTIONAL ). " Avoiding false-positives (inheriting from global class which is out of scan scope) result = xsdbool( defined_superclass-has_framework = abap_true @@ -206,7 +210,8 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION. RETURN. ENDTRY. - IF NOT line_exists( defined_classes[ name = class_name + IF NOT line_exists( defined_classes[ program_name = program_name + class_name = class_name has_framework = abap_false ] ). RETURN. ENDIF. @@ -238,7 +243,8 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION. METHOD get_forbidden_tokens. - DATA(class) = VALUE #( defined_classes[ name = class_name ] OPTIONAL ). + DATA(class) = VALUE #( defined_classes[ program_name = program_name + class_name = class_name ] OPTIONAL ). DATA(risk_lvl) = COND #( WHEN class IS NOT INITIAL THEN class-risk_level ELSE space ).