From 59e30143d374adccfd5ae93c71cc565dd600ecad Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Mon, 18 Jan 2021 17:41:35 -0300 Subject: [PATCH 01/15] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 2409440f..ba6c1986 100644 --- a/README.md +++ b/README.md @@ -38,6 +38,8 @@ The Profile Management Tool, which is an alternative of working with SCI based v - Multiple execution of several profiles at the same time (the sharpest/strongest and time valid configuration/threshold will be taken); - Delegation principle to facilitate team work (all delegates, for instance: team members, can work with the same profile); +:warning: The checks are not RFC-Enabled due to local dependencies. + ## List of Checks - [Check Documentation](docs/check_documentation.md) From 157a09d55f56d8784a9acf48ba0807daa678f7e1 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Mon, 18 Jan 2021 21:46:45 +0100 Subject: [PATCH 02/15] disabling rfc --- src/foundation/y_check_base.clas.abap | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/foundation/y_check_base.clas.abap b/src/foundation/y_check_base.clas.abap index 6d747f4a..a0bba4b7 100644 --- a/src/foundation/y_check_base.clas.abap +++ b/src/foundation/y_check_base.clas.abap @@ -127,7 +127,6 @@ CLASS y_check_base DEFINITION PUBLIC ABSTRACT METHODS do_attributes_exist RETURNING VALUE(result) TYPE abap_bool. METHODS instantiate_objects. - METHODS enable_rfc. METHODS is_skipped IMPORTING config TYPE y_if_clean_code_manager=>check_configuration error_count TYPE int4 @@ -178,7 +177,6 @@ CLASS y_check_base IMPLEMENTATION. METHOD constructor. super->constructor( ). - enable_rfc( ). description = get_class_description( ). category = 'Y_CATEGORY_CODE_PAL'. @@ -709,19 +707,6 @@ CLASS y_check_base IMPLEMENTATION. ENDMETHOD. - METHOD enable_rfc. - ASSIGN me->('remote_rfc_enabled') TO FIELD-SYMBOL(). - IF sy-subrc = 0. - = abap_true. - ENDIF. - ASSIGN me->('remote_enabled') TO FIELD-SYMBOL(). - IF sy-subrc = 0. - = abap_true. - ENDIF. - UNASSIGN: , . - ENDMETHOD. - - METHOD set_check_message. y_message_registration=>add_message( EXPORTING From 0e231368e44f6e0d8c0eaaaed5521a9ef7469a18 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Tue, 19 Jan 2021 08:28:44 -0300 Subject: [PATCH 03/15] Update changelog.txt --- changelog.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changelog.txt b/changelog.txt index 646c74a3..b96a80aa 100644 --- a/changelog.txt +++ b/changelog.txt @@ -12,6 +12,10 @@ Upgrade Note ------------------ Whenever you upgrade code pal for ABAP, it is highly recommended to execute the Y_CI_CHECK_REGISTRATION report to activate/reactivate the Checks (SE38 transaction) and regenerate the respective code inspector variant (SCI transaction) +2021-01-XX v1.12.0 +------------------ +- RFC Enabled (#305) + 2021-01-18 v1.11.0 ------------------ * CHECK position after comments (#301) From 1fb7884000f24c095b41b0338a244ca45eb3c2d7 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Tue, 19 Jan 2021 11:33:04 -0300 Subject: [PATCH 04/15] Update changelog.txt --- changelog.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.txt b/changelog.txt index b96a80aa..87234782 100644 --- a/changelog.txt +++ b/changelog.txt @@ -14,7 +14,7 @@ Whenever you upgrade code pal for ABAP, it is highly recommended to execute the 2021-01-XX v1.12.0 ------------------ -- RFC Enabled (#305) +- RFC Disabled (#305) 2021-01-18 v1.11.0 ------------------ From 6b10dd63c5e0fe3e8824c5565d4d60543a82bc01 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Fri, 22 Jan 2021 18:21:03 +0100 Subject: [PATCH 05/15] 1.12.0 --- src/y_code_pal_version.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/y_code_pal_version.intf.abap b/src/y_code_pal_version.intf.abap index 6f471941..1c3cca2c 100644 --- a/src/y_code_pal_version.intf.abap +++ b/src/y_code_pal_version.intf.abap @@ -1,3 +1,3 @@ INTERFACE y_code_pal_version PUBLIC. - CONSTANTS abap TYPE string VALUE '1.11.1' ##NO_TEXT. + CONSTANTS abap TYPE string VALUE '1.12.0' ##NO_TEXT. ENDINTERFACE. From 0ba96c6aa58cd1368561b4fc85cf114b018e39ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eugen=20G=C3=BCnther?= <64586309+eugen-guenther-sap@users.noreply.github.com> Date: Mon, 25 Jan 2021 13:59:19 +0100 Subject: [PATCH 06/15] Profile Tool - UX Refinement (#313) Minor UX Changes --- src/profiles/y_alv_tree_control.clas.abap | 68 ++++++++++++------- src/profiles/y_if_alv_tree_control.intf.abap | 10 ++- src/profiles/y_list.clas.abap | 21 +++--- .../y_profile_admin_classes.prog.abap | 24 ++++++- src/profiles/y_profile_administrator.prog.xml | 24 ++----- 5 files changed, 91 insertions(+), 56 deletions(-) diff --git a/src/profiles/y_alv_tree_control.clas.abap b/src/profiles/y_alv_tree_control.clas.abap index ed7e6764..c8872987 100644 --- a/src/profiles/y_alv_tree_control.clas.abap +++ b/src/profiles/y_alv_tree_control.clas.abap @@ -1,6 +1,4 @@ -CLASS y_alv_tree_control DEFINITION - PUBLIC - CREATE PUBLIC . +CLASS y_alv_tree_control DEFINITION PUBLIC CREATE PUBLIC. PUBLIC SECTION. @@ -18,18 +16,18 @@ CLASS y_alv_tree_control DEFINITION events TYPE REF TO y_if_alv_events event_mode TYPE i DEFAULT y_if_alv_events=>mode_double_click RETURNING - VALUE(result) TYPE REF TO y_if_alv_tree_control + VALUE(result) TYPE REF TO y_if_alv_tree_control RAISING cx_sy_create_data_error cx_failed. METHODS constructor IMPORTING - type_name TYPE string - sort_table TYPE lvc_t_sort - events TYPE REF TO y_if_alv_events - alv_tree TYPE REF TO cl_gui_alv_tree_simple - alv_header TYPE slis_t_listheader + type_name TYPE string + sort_table TYPE lvc_t_sort + events TYPE REF TO y_if_alv_events + alv_tree TYPE REF TO cl_gui_alv_tree_simple + alv_header TYPE slis_t_listheader RAISING cx_sy_create_data_error cx_failed. @@ -51,7 +49,7 @@ ENDCLASS. -CLASS y_alv_tree_control IMPLEMENTATION. +CLASS Y_ALV_TREE_CONTROL IMPLEMENTATION. METHOD autosize_all_fields. @@ -77,13 +75,14 @@ CLASS y_alv_tree_control IMPLEMENTATION. METHOD create. - DATA(docking_container) = NEW cl_gui_docking_container( repid = sy_repid - dynnr = dynpro_nr - side = docking_side - ratio = ratio ). + DATA(docking_container) = NEW cl_gui_docking_container( repid = sy_repid + dynnr = dynpro_nr + side = docking_side + ratio = ratio ). DATA(alv_tree) = NEW cl_gui_alv_tree_simple( i_parent = docking_container - i_item_selection = '' ). + i_item_selection = abap_false + i_no_html_header = abap_true ). alv_tree->get_toolbar_object( IMPORTING er_toolbar = DATA(alv_toolbar) ). @@ -134,9 +133,9 @@ CLASS y_alv_tree_control IMPLEMENTATION. IF sy-subrc EQ 0. alv_tree->get_selected_nodes( CHANGING ct_index_outtab = index_table ). TRY. - result = index_table[ 1 ]. - CATCH cx_sy_itab_line_not_found. - RAISE EXCEPTION TYPE ycx_entry_not_found. + result = index_table[ 1 ]. + CATCH cx_sy_itab_line_not_found. + RAISE EXCEPTION TYPE ycx_entry_not_found. ENDTRY. ENDIF. ENDMETHOD. @@ -154,11 +153,8 @@ CLASS y_alv_tree_control IMPLEMENTATION. dp_error = 2 failed = 3 error_in_node_key_table = 4 - others = 5 - ). "#EC OPTL_EXP - IF SY-SUBRC <> 0. - BREAK-POINT. - ENDIF. + OTHERS = 5 + ). ENDMETHOD. @@ -175,7 +171,7 @@ CLASS y_alv_tree_control IMPLEMENTATION. alv_tree->set_table_for_first_display( EXPORTING - it_list_commentary = alv_header + it_list_commentary = alv_header it_toolbar_excluding = get_excluded_toolbars( ) CHANGING it_sort = sort @@ -226,4 +222,28 @@ CLASS y_alv_tree_control IMPLEMENTATION. METHOD y_if_alv_tree_control~to_focus. cl_gui_control=>set_focus( alv_tree ). ENDMETHOD. + + + METHOD y_if_alv_tree_control~activate_toolbar. + LOOP AT y_if_alv_tree_control~toolbar_control( )->m_table_button ASSIGNING FIELD-SYMBOL(