feat: generalize retry/backoff UI with improved feedback #9088
+1,228
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with cause
- Replace rateLimitRetrySchema with retryStatusSchema including cause and rateLimitSeconds fields
- Add new RetryStatusRow component with differentiated messaging:
- Rate limit: 'Rate limit set to {{rateLimitSeconds}} seconds' (title) + 'Waiting {{seconds}} seconds' (subtitle)
- Retry: Error message (title) + 'Trying in {{seconds}} seconds (attempt #{{attempt}})' (subtitle)
- Update Task.say emitters to use retryStatus metadata with appropriate cause:
- 'rate_limit' for provider window waits and 429 errors (includes rateLimitSeconds)
- 'backoff' for exponential backoff retries
- Migrate i18n keys from rateLimitRetry to retryStatus with new nested structure in English
- Maintain backward compatibility with legacy rateLimitRetry metadata
- Update tests to cover new RetryStatusRow component and metadata structure
- Migrate chat.rateLimitRetry.* → chat.retryStatus.* across 17 locales - Add nested structure: retryStatus.rateLimit.* and retryStatus.backoff.* - Provide contextual messaging for rate limits vs exponential backoff
No new issues found in commit 945c0ff. The commit removes unused legacy code (the TODO:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
dosubot
bot
added
size:XL
6 tasks
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
webview-ui/src/components/chat/__tests__/RetryStatusRow.spec.tsx
Outdated
Show resolved
Hide resolved
webview-ui/src/components/chat/__tests__/RetryStatusRow.spec.tsx
Outdated
Show resolved
Hide resolved
…empts and empty metadata cases - Add support for attempt/maxAttempts parameters in rate limit scenarios - Return default backoff waiting message when metadata is missing - Fix test expectations to match component output - All 6 tests now passing
webview-ui/src/components/chat/__tests__/RetryStatusRow.spec.tsx
Outdated
Show resolved
Hide resolved
…ây'; update RetryStatusRow tests
mrubens
reviewed
Nov 7, 2025
mrubens
reviewed
Nov 8, 2025
Comment on lines
+152
to
+175
| "retryStatus": { | ||
| "rateLimit": { | ||
| "title": "Rate limit set to {{rateLimitSeconds}} seconds", | ||
| "waiting": "Waiting {{seconds}} seconds", | ||
| "proceeding": "Proceeding now…", | ||
| "cancelled": "Request cancelled" | ||
| }, | ||
| "backoff": { | ||
| "title": "Request failed", | ||
| "waiting": "Trying in {{seconds}} seconds", | ||
| "waitingWithAttempt": "Trying in {{seconds}} seconds (attempt #{{attempt}})", | ||
| "waitingWithAttemptMax": "Trying in {{seconds}} seconds (attempt #{{attempt}}/{{maxAttempts}})", | ||
| "retrying": "Trying now…", | ||
| "cancelled": "Retry cancelled" | ||
| } | ||
| }, | ||
| "rateLimitRetry": { | ||
| "title": "Rate limit triggered — please wait.", | ||
| "waiting": "Retrying in {{seconds}}s", | ||
| "waitingWithAttempt": "Retrying in {{seconds}}s (attempt {{attempt}})", | ||
| "waitingWithAttemptMax": "Retrying in {{seconds}}s (attempt {{attempt}}/{{maxAttempts}})", | ||
| "retrying": "Retrying now…", | ||
| "cancelled": "Retry cancelled" | ||
| }, |
Collaborator
There was a problem hiding this comment.
I'm kind of confused here - I thought there were only two cases (rate limits and errors). What's the difference between the second and the third?
Collaborator
There was a problem hiding this comment.
In general I prefer "Retrying" to "Trying" in these strings btw
|
@CodiumAI-Agent /review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7922
This PR generalizes the rate-limit UI to a more generic retry/backoff interface with improved user feedback and comprehensive translations.
Changes
Supersedes
This PR supersedes #8503 and incorporates the same functionality but with a slightly different UI.
Screenshots
Thanks to @elianiva for the original contribution!
Co-authored-by: elianiva [email protected]
Important
Generalizes retry/backoff UI with improved feedback, new schemas, components, and comprehensive translations.
retryStatusSchemaandrateLimitRetrySchemainmessage.ts.RetryStatusRowandRateLimitRetryRowcomponents inChatRow.tsx.This description was created by
for fca211b. You can customize this summary. It will automatically update as commits are pushed.