Skip to content

Commit 9aca3b6

Browse files
committed
remove unnecessary code
1 parent 521064e commit 9aca3b6

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

ocp_resources/node_network_configuration_policy.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -370,11 +370,6 @@ def _process_failed_status(self, failed_condition_reason):
370370

371371
raise NNCPConfigurationFailed(f"Reason: {failed_condition_reason}\n{last_err_msg}")
372372

373-
def get_available_condition(self):
374-
for condition in self.instance.get("status", {}).get("conditions", []):
375-
if condition["type"] == self.Conditions.Type.AVAILABLE:
376-
return condition
377-
378373
@retry(wait_timeout=120, sleep=5)
379374
def wait_for_status_success(self):
380375
failed_condition_reason = self.Conditions.Reason.FAILED_TO_CONFIGURE
@@ -385,16 +380,16 @@ def wait_for_status_success(self):
385380
for condition in self.instance.get("status", {}).get("conditions", [])
386381
if condition and condition["type"] == self.Conditions.Type.AVAILABLE
387382
]
388-
if available_condition and available_condition[0]["status"] == self.Condition.Status.TRUE:
389-
self.logger.info(f"NNCP {self.name} configured Successfully")
390-
return available_condition
383+
if available_condition:
384+
if available_condition[0]["status"] == self.Condition.Status.TRUE:
385+
self.logger.info(f"NNCP {self.name} configured Successfully")
386+
return available_condition
391387

392-
elif available_condition[0]["reason"] == no_match_node_condition_reason:
393-
raise NNCPConfigurationFailed(f"{self.name}. Reason: {no_match_node_condition_reason}")
388+
elif available_condition[0]["reason"] == no_match_node_condition_reason:
389+
raise NNCPConfigurationFailed(f"{self.name}. Reason: {no_match_node_condition_reason}")
394390

395-
elif available_condition[0]["reason"] == failed_condition_reason:
396-
self.logger.error(f"Available condition: {available_condition}")
397-
self._process_failed_status(failed_condition_reason=failed_condition_reason)
391+
elif available_condition[0]["reason"] == failed_condition_reason:
392+
self._process_failed_status(failed_condition_reason=failed_condition_reason)
398393

399394
@property
400395
def nnces(self):

0 commit comments

Comments
 (0)