Skip to content

Conversation

@asroy
Copy link
Contributor

@asroy asroy commented Feb 15, 2023

Without built-in function:
image

With built-in function (this PR):
image

@asroy asroy requested a review from zjing14 February 15, 2023 20:57
zjing14
zjing14 previously approved these changes Feb 15, 2023
@zjing14
Copy link
Contributor

zjing14 commented Feb 23, 2023

CI failed with the following warning:

[2023-02-22T20:58:28.811Z] /home/jenkins/workspace/mposable_kernel_builtin_fastgelu/include/ck/tensor_operation/gpu/element/unary_element_wise_operation.hpp:15:29: warning: identifier 'ocml_native_recip_f32' is reserved because it starts with '' [-Wreserved-identifier]

[2023-02-22T20:58:28.811Z] extern "C" device float __ocml_native_recip_f32(float);

@asroy
Copy link
Contributor Author

asroy commented Feb 23, 2023

CI failed with the following warning:

[2023-02-22T20:58:28.811Z] /home/jenkins/workspace/mposable_kernel_builtin_fastgelu/include/ck/tensor_operation/gpu/element/unary_element_wise_operation.hpp:15:29: warning: identifier 'ocml_native_recip_f32' is reserved because it starts with '' [-Wreserved-identifier]

[2023-02-22T20:58:28.811Z] extern "C" device float __ocml_native_recip_f32(float);

It actually failed because of some function is missing, which I'm trying to fix

The "xtern "C" device float __ocml_native_recip_f32(float)" is a warning

@zjing14 zjing14 merged commit 8f45561 into develop Feb 27, 2023
carlushuang pushed a commit that referenced this pull request Mar 6, 2023
* clean up

* fast gelu using builtin function

* clean

* clean

* clean

* clean:

* clean

* fix compilation

* clean

* clean

---------

Co-authored-by: zjing14 <[email protected]>
@illsilin illsilin deleted the builtin_fastgelu branch December 7, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants