[CK_TILE] Remove Old CK Tile Stream-K Artifacts #3202
Draft
+4,301
−3,806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k GEMM. - This commit lays the groundwork for integrating the tile engine into streamk GEMM. It focuses on creating benchmark executables for streamk GEMM. - Additional scripts like test_benchmark.sh and gemm_benchmark.py will be added once the streamk implementation reaches stability.
…ated implementation
…put of CK TILE STREAMK
* Add gtests for compiler CI for faster testing * Add changes to have a custom target * Add a gtest suite for gemm kernel for running CI tests with compiler mode * Fix Clang error (EOL) * Removed compiler subfolder from CMake * Add gtest suite for gemm kernel * Disable failed tests * Fix build errors * Resolved PR comments * Update shape for persistent gemm kernel test * Seperated types by H/W archs * Made changes to persistent types * Fix persistent build failure issue --------- Co-authored-by: Thomas Ning <[email protected]>
The original CK Stream-K implementation used a Tile Partitioner that was based on old CK's Stream-K block to C tile map. However, old CK's implementation did not align with the original Stream-K paper. Thus, we implemented a new Tile Partitioner and associated Stream-K Kernel. The kernel implementation was placed in the reboot namespace. Now that all functionality for the new implementation is in place, this change makes the following changes: - Removes all uses of the old CK Tile Stream-K implementation. - Removes the reboot namespace such that the new implementation is in the ck_tile namespace only. - Adds tests for fp8 and bf8 for the new implementation as these were only in place for the old implementation. - Removes the old CK Tile Stream-K Tile partitioner - Remove the v2 suffix from the new CK Tile Tile Partitioner derived classes.
ecamartins
force-pushed
the
emimarti/ck_tile/remove_old_streamk
branch
from
d0a9119 to
2ef3ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The original CK Stream-K implementation used a Tile Partitioner that was based on old CK's Stream-K block to C tile map. However, old CK's implementation did not align with the original Stream-K paper. Thus, we implemented a new Tile Partitioner (#3018) and associated Stream-K Kernel (#3064). The new CK Tile Stream-K kernel implementation was placed in the
rebootnamespace.Now that all functionality for the new implementation is in place, including examples (#3107) and tile engine (#3157), we can now remove the old CK tile Stream-K implementation. Thus, this PR makes the following changes:
rebootnamespace such that the new implementation is in theck_tilenamespace only.Note: This PR is dependent on #3157. I will mark this PR as ready for review once #3157 has merged
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files