Skip to content

Commit d69b1a0

Browse files
committed
Merge remote-tracking branch 'origin/pr/404'
* origin/pr/404: Fix updating template switcher progress bar
2 parents a46eaa1 + 8fa2447 commit d69b1a0

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

qubesmanager/common_threads.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ def run(self):
7575

7676

7777
class ChangeTemplatesThread(QtCore.QThread):
78-
def __init__(self, progress_dialog, items_to_change, qubes_app):
78+
def __init__(self, main_dialog, items_to_change, qubes_app):
7979
super().__init__()
80-
self.dialog = progress_dialog
80+
self.main_dialog = main_dialog
8181
self.items = items_to_change
8282
self.qubes_app = qubes_app
8383
self.errors = {}
@@ -91,4 +91,4 @@ def run(self):
9191
'template', row.new_item.currentText())
9292
except Exception as ex: # pylint: disable=broad-except
9393
self.errors[vm] = str(ex)
94-
self.dialog.setValue(i)
94+
self.main_dialog.progress_signal.emit(i)

qubesmanager/template_manager.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
class TemplateManagerWindow(
4040
ui_templatemanager.Ui_MainWindow, QtWidgets.QMainWindow):
4141

42+
progress_signal = QtCore.pyqtSignal(int)
43+
4244
def __init__(self, qt_app, qubes_app, dispatcher, parent=None):
4345
# pylint: disable=unused-argument
4446
super().__init__(parent)
@@ -247,13 +249,16 @@ def apply(self):
247249
self.dialog.setCancelButton(None)
248250
self.dialog.setModal(True)
249251
self.dialog.show()
250-
251-
self.thread = common_threads.ChangeTemplatesThread(self.dialog,
252+
self.progress_signal.connect(self.on_progress_changed)
253+
self.thread = common_threads.ChangeTemplatesThread(self,
252254
items_to_change,
253255
self.qubes_app)
254256
self.thread.finished.connect(self.finish_changes)
255257
self.thread.start()
256258

259+
def on_progress_changed(self, value):
260+
self.dialog.setValue(value)
261+
257262
def finish_changes(self):
258263
self.dialog.hide()
259264

0 commit comments

Comments
 (0)