Skip to content

Maximize Updater GUI on openQA display #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Maximize Updater GUI on openQA display #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions qui/updater.glade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,8 @@ Selected qubes will be automatically started if necessary and shutdown after suc
<property name="margin-top">30</property>
<property name="margin-bottom">5</property>
<property name="label" translatable="yes">The following qubes need to be restarted to use an updated template (to configure restarting qubes by default, go to 'Updater Settings' in the top right corner of this window):</property>
<property name="use-markup">True</property>
<property name="wrap">True</property>
</object>
<packing>
<property name="expand">False</property>
Expand Down
9 changes: 5 additions & 4 deletions qui/updater/updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,13 @@ def cell_data_func(_column, cell, model, it, data):
width = self.intro_page.vm_list.get_preferred_width().natural_width
# Wide enough for details section to show update progress.
# But still less than 1024 pixels to do not break OpenQA tests.
screen = self.main_window.get_screen()
width = max(width, 1000)
width = min(width, self.main_window.get_screen().get_width() - 12)
height = min(
int(width * 1.2), self.main_window.get_screen().get_height() - 48
)
width = min(width, screen.get_width() - 12)
height = min(int(width * 1.2), screen.get_height() - 100)
self.main_window.resize(width + 50, height)
if screen.get_width() <= 1024 or screen.get_height() < 768:
self.main_window.maximize()
self.main_window.set_size_request(800, 600) # Smaller is meaningless
self.main_window.set_position(Gtk.WindowPosition.CENTER_ALWAYS)

Expand Down